Split permission checks #486

Merged
merged 14 commits into from Oct 26, 2014

Conversation

Projects
None yet
3 participants
@rachelbaker
Member

rachelbaker commented Sep 19, 2014

Began moving object permission checks into global functions. This begins the process with the Post permission checks. We will also need to do this for Users and Terms.

ef44a2d Changes my initial approach based on feedback from @rmccue

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Sep 19, 2014

Member

@rmccue #reviewmerge

Member

rachelbaker commented Sep 19, 2014

@rmccue #reviewmerge

@rachelbaker

This comment has been minimized.

Show comment
Hide comment
@rachelbaker

rachelbaker Sep 19, 2014

Member

Blocking #378

Member

rachelbaker commented Sep 19, 2014

Blocking #378

@rachelbaker rachelbaker added the Review label Sep 24, 2014

@rachelbaker rachelbaker added this to the 1.2 milestone Sep 24, 2014

@rachelbaker rachelbaker merged commit ef44a2d into master Oct 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
+ * @param string $capability Permission to check.
+ * @return boolean Can we interact with it?
+ */
+function json_check_post_permission( $post, $capability = 'read' ) {

This comment has been minimized.

@danielbachhuber

danielbachhuber Oct 27, 2014

Member

Won't we need json_check_user_permission, json_check_comment_permission, and json_check_term_permission, etc correspondingly?

@danielbachhuber

danielbachhuber Oct 27, 2014

Member

Won't we need json_check_user_permission, json_check_comment_permission, and json_check_term_permission, etc correspondingly?

@rachelbaker rachelbaker deleted the split-permission-checks branch Oct 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment