Test post endpoints #99

rachelbaker · 2014-05-26T21:13:37Z

The WP_JSON_Posts endpoints should be tested to ensure they return a reliable representation of posts.


        Added basic create and edit post tests.


        Added header tests to create and new posts.


        Added test for returning a single post.


        Added response test for edit context of edit_post endpoint.


        Added format, password, date and modified date tests to check_get_pos…

…t_response.

rachelbaker · 2014-05-26T21:15:03Z

Began adding unit tests for the /posts/ endpoints, still a long way to go to get close to full coverage.

rmccue · 2014-05-27T07:17:47Z

tests/test_json_posts.php

+		}
+
+		// Check post dates.
+		$timezone = $this->fake_server->get_timezone();


This returns null, since everything is stubbed out, but the same happens internally too, so...

rmccue · 2014-05-27T07:21:14Z

Coverage is currently at 47.96%.


        Create abstract base test class


        Check correct date for creation


        Check other post types


        Add more post creation tests


        Use (int) not absint for author sanitization


        Check _raw fields with edit context


        Add extra braces

This helps coverage understand the code better, and fits with coding standards.


        Create post as test user


        Test more post editing


        Test post creation permissions


        Return 403 error if user can't create posts


        Check with invalid post author object


        Test creating draft and private posts


        Give `null` as date for draft posts


        Test password-protected posts


        Check page creation with parent


        Partially revert "Give `null` as date for draft posts"

This reverts commit 2bde2c2. This is going to be fixed in #229 instead.


        Correct post parent tests


        Ensure assertions are always `$expected, $actual`


        Add missing base testcase

Duh.


        Use tabs vs spaces in the test config file.


        Added test for get_revisions method.


        Test creating post with custom date


        Don't mock out server methods

This never should have been disabled, and was causing stupid errors. We can remove this when we refactor in #185.


        Test dates with custom TZs/GMT


        Test that custom modified dates are ignored

As per #285.


        Test menu order


        Test sticky posts


        Merge branch 'master' into test-post-endpoints


        Mark password test skipped


        Don't skip parent tests

Now that #228 has been fixed, we can reenable these.


        Don't skip draft test

We've now corrected the date issue in #229. Wa-hoo!


        Test invalid statuses

rmccue · 2014-06-02T14:09:00Z

We're now at 54% coverage for tests (my previous figure was wrong; it was closer to 10%); more importantly, insert_post is at 81%, with that figure to increase dramatically once #218 and #286 are fixed.

Merging for now so that we can avoid this going stale, and so that it helps us in the mean time. More tests to come!


        Merge pull request #99 from WP-API/test-post-endpoints

Test post endpoints

rachelbaker · 2014-06-02T14:33:55Z

👏


        Merge pull request WP-API#99 from WP-API/test-post-endpoints

Test post endpoints

rmccue added this to the 1.0 milestone Mar 4, 2014

rmccue added Enhancement labels Mar 4, 2014

This was referenced Mar 4, 2014

Test media endpoints #100

Closed

Test CPT endpoints #101

Closed

Create unit tests #6

Closed

rmccue modified the milestones: 1.1, 1.0 Apr 9, 2014

rachelbaker added 5 commits May 25, 2014

Added basic create and edit post tests.

7da000a

Added header tests to create and new posts.

9264a73

Added test for returning a single post.

389de68

Added response test for edit context of edit_post endpoint.

3dc1f3d

Added format, password, date and modified date tests to check_get_pos…

Loading status checks…

b3f1d32

…t_response.

rachelbaker self-assigned this May 26, 2014

rmccue mentioned this pull request May 27, 2014

Fix errors with excerpt #226

Merged

rmccue reviewed May 27, 2014
View changes

tests/test_json_posts.php Outdated

}

// Check post dates.

$timezone = $this->fake_server->get_timezone();

This comment has been minimized.

Sign in to view

Copy link

rmccue May 27, 2014
Member

This returns null, since everything is stubbed out, but the same happens internally too, so...

rmccue added 12 commits May 27, 2014

Create abstract base test class

6b5c739

Check correct date for creation

8b507a5

Check other post types

36cdb6c

Add more post creation tests

99c47a4

Use (int) not absint for author sanitization

43a3953

Check _raw fields with edit context

852fc95

Add extra braces

ce811f5

This helps coverage understand the code better, and fits with coding standards.

Create post as test user

c28b467

Test more post editing

af34612

Test post creation permissions

33eacca

Return 403 error if user can't create posts

Loading status checks…

0b08c8c

Check with invalid post author object

dd99e90

rmccue and others added 21 commits May 27, 2014

Test creating draft and private posts

fe4bb02

Give `null` as date for draft posts

Loading status checks…

2bde2c2

Test password-protected posts

36b065c

Check page creation with parent

bd5b90f

Partially revert "Give `null` as date for draft posts"

4b9fb1a

This reverts commit 2bde2c2. This is going to be fixed in #229 instead.

Correct post parent tests

4f70d01

Ensure assertions are always `$expected, $actual`

Loading status checks…

90f5372

Add missing base testcase

Loading status checks…

198125a

Duh.

Use tabs vs spaces in the test config file.

Loading status checks…

e950f1a

Added test for get_revisions method.

Loading status checks…

f35a0e3

Test creating post with custom date

66c7457

Don't mock out server methods

3af845e

This never should have been disabled, and was causing stupid errors. We can remove this when we refactor in #185.

Test dates with custom TZs/GMT

ab95e87

Test that custom modified dates are ignored

1e6b92d

As per #285.

Test menu order

Loading status checks…

19a01ad

Test sticky posts

Loading status checks…

e03b13b

Merge branch 'master' into test-post-endpoints

ba34f4b

Mark password test skipped

Loading status checks…

c4cb0a1

Don't skip parent tests

be57075

Now that #228 has been fixed, we can reenable these.

Don't skip draft test

Loading status checks…

385af45

We've now corrected the date issue in #229. Wa-hoo!

Test invalid statuses

Loading status checks…

20401af

rmccue added a commit that referenced this pull request Jun 2, 2014

Merge pull request #99 from WP-API/test-post-endpoints

Loading status checks…

bc40226

Test post endpoints

rmccue merged commit bc40226 into master Jun 2, 2014
1 check passed

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

rmccue deleted the test-post-endpoints branch Jun 2, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Merge pull request WP-API#99 from WP-API/test-post-endpoints

0b7c26b

Test post endpoints

WP-API / WP-API Archived

Test post endpoints #99

Test post endpoints #99

rachelbaker commented May 26, 2014

rachelbaker commented May 26, 2014

This comment has been minimized.

rmccue commented May 27, 2014

rmccue commented Jun 2, 2014

rachelbaker commented Jun 2, 2014

WP-API / WP-API Archived

Join GitHub today

Test post endpoints #99

Test post endpoints #99

Conversation

rachelbaker commented May 26, 2014

rachelbaker commented May 26, 2014

This comment has been minimized.

rmccue May 27, 2014

rmccue commented May 27, 2014

rmccue commented Jun 2, 2014

rachelbaker commented Jun 2, 2014