Implement .transport() prototype method & document transport customization
#221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization This follows #220 by providing a method by which transport functions can be set on a preexisting `WP` instance object, such as one returned through the auto-discovery flow. Documentation around HTTP behavior customization and extension has been added to the README.
kadamwhite
force-pushed
the
implement-and-document-wp-instance-transport-method
branch
from
9d22bab to
45ee6ec
Compare
kadamwhite
deleted the
implement-and-document-wp-instance-transport-method
branch
kadamwhite
added a commit
that referenced
this pull request
Dec 5, 2016
In #181 auto-discovery was added that permits a consumer of this library to automatically locate the API root for a given WordPress site (specified by URL), and in most cases to automatically detect & initialize specific route handlers for the API routes available on that site. However, these methods were never updated to account for #221, which added the ability to replace the default HTTP transport (superagent) with a custom implementation or a wrapper. This meant that even if the consumer had specified their own transport, for example jQuery, there would still be a dependency on superagent should they wish to use the auto-discovery capabilities of the library. This PR updates the auto-discovery logic to use the same HTTP transport layer as the rest of the client, which has the added benefit of removing a number of duplicative logic that existed in the auto-discovery module.
This was referenced Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #220 by providing a method by which transport functions can be set on a preexisting
WPinstance object, such as one returned through the auto-discovery flow. Documentation around HTTP behavior customization and extension has been added to the README.