New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next submission link - fixes #19 #21

Merged
merged 11 commits into from Nov 6, 2014

Conversation

Projects
None yet
2 participants
@enterprisey
Member

enterprisey commented Jul 20, 2014

Fix #19

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Jul 21, 2014

Contributor

Cool! About to get on a flight, will review when I land. :)

Contributor

theopolisme commented Jul 21, 2014

Cool! About to get on a flight, will review when I land. :)

Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
Show outdated Hide outdated src/modules/submissions.js Outdated
@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Jul 21, 2014

Contributor

Cool stuff going on, a few comments.

Contributor

theopolisme commented Jul 21, 2014

Cool stuff going on, a few comments.

@enterprisey

This comment has been minimized.

Show comment
Hide comment
@enterprisey

enterprisey Jul 21, 2014

Member

Thanks! I plan to fix all of these soon.

Member

enterprisey commented Jul 21, 2014

Thanks! I plan to fix all of these soon.

@enterprisey

This comment has been minimized.

Show comment
Hide comment
@enterprisey

enterprisey Jul 22, 2014

Member

@theopolisme Fixed the issues; what do you think?

Member

enterprisey commented Jul 22, 2014

@theopolisme Fixed the issues; what do you think?

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Jul 22, 2014

Contributor

pagename undefined, assuming you meant title?

Contributor

theopolisme commented on src/modules/submissions.js in 3c87e07 Jul 22, 2014

pagename undefined, assuming you meant title?

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Jul 22, 2014

Contributor

Mixed spaces and tabs seem to be making jshint mad?

Contributor

theopolisme commented on src/modules/submissions.js in 3c87e07 Jul 22, 2014

Mixed spaces and tabs seem to be making jshint mad?

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Jul 22, 2014

Contributor

Looking good, almost there.

Just curious, have you been able to set up a testing environment (e.g. User:APerson/afch-dev.js on enwiki)? Just install node and npm (really easy, instructions online). Then run npm install in the main directory, this will install all dependencies automagically. Then just run python scripts/upload.py using your username, password, and desired on-wiki location (instructions are included at the top of the script). This way you'll be able to check and make sure everything works functionality-wise.

Really glad to have someone else interested in actually writing code for the project!

Cheers,
Theo

Contributor

theopolisme commented Jul 22, 2014

Looking good, almost there.

Just curious, have you been able to set up a testing environment (e.g. User:APerson/afch-dev.js on enwiki)? Just install node and npm (really easy, instructions online). Then run npm install in the main directory, this will install all dependencies automagically. Then just run python scripts/upload.py using your username, password, and desired on-wiki location (instructions are included at the top of the script). This way you'll be able to check and make sure everything works functionality-wise.

Really glad to have someone else interested in actually writing code for the project!

Cheers,
Theo

@enterprisey

This comment has been minimized.

Show comment
Hide comment
@enterprisey

enterprisey Jul 22, 2014

Member

@theopolisme Further issues fixed. I'm going to set a testing environment up soon.

Member

enterprisey commented Jul 22, 2014

@theopolisme Further issues fixed. I'm going to set a testing environment up soon.

@enterprisey

This comment has been minimized.

Show comment
Hide comment
@enterprisey

enterprisey Jul 24, 2014

Member

@theopolisme Do you think that this branch can be merged?

Member

enterprisey commented Jul 24, 2014

@theopolisme Do you think that this branch can be merged?

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Jul 24, 2014

Contributor

Uh, probably, but it'd be great if you could test it in a test environment first..

Contributor

theopolisme commented Jul 24, 2014

Uh, probably, but it'd be great if you could test it in a test environment first..

@enterprisey

This comment has been minimized.

Show comment
Hide comment
@enterprisey

enterprisey Jul 24, 2014

Member

I'm currently setting up the test environment.

Member

enterprisey commented Jul 24, 2014

I'm currently setting up the test environment.

@enterprisey

This comment has been minimized.

Show comment
Hide comment
@enterprisey

enterprisey Jul 25, 2014

Member

I successfully set up the test environment and everything, but data.query.categorymembers[0] (from line 485) doesn't seem to be working. Will fix as soon as I can.

Member

enterprisey commented Jul 25, 2014

I successfully set up the test environment and everything, but data.query.categorymembers[0] (from line 485) doesn't seem to be working. Will fix as soon as I can.

@enterprisey

This comment has been minimized.

Show comment
Hide comment
@enterprisey

enterprisey Aug 4, 2014

Member

I've been testing, and for some inexplicable reason it's started working. The code is currently hosted in my userspace. Someone please confirm that it's working, and then merge.

Member

enterprisey commented Aug 4, 2014

I've been testing, and for some inexplicable reason it's started working. The code is currently hosted in my userspace. Someone please confirm that it's working, and then merge.

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Nov 4, 2014

Contributor

Stale? If you just fix the current merge conflicts then we should totally merge this!

Contributor

theopolisme commented Nov 4, 2014

Stale? If you just fix the current merge conflicts then we should totally merge this!

@enterprisey enterprisey merged commit 851e6c3 into master Nov 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@enterprisey enterprisey deleted the next-submission-link branch Nov 6, 2014

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Nov 6, 2014

Contributor

ick, that merge looked really weird.. working on fixing it now

Contributor

theopolisme commented Nov 6, 2014

ick, that merge looked really weird.. working on fixing it now

@theopolisme theopolisme restored the next-submission-link branch Nov 6, 2014

@theopolisme theopolisme deleted the next-submission-link branch Nov 6, 2014

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Nov 6, 2014

Contributor

I think some rebasing may have fixed it...

Contributor

theopolisme commented Nov 6, 2014

I think some rebasing may have fixed it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment