Permalink
Browse files

Add User input option to every page affecting change.

In cases where there is no user input we default to not patrol.
Supports issue 215
  • Loading branch information...
hasteur committed Mar 13, 2014
1 parent 95efce8 commit 1d4e95874be245b3abeda0719e49ec0ac0e9fbf5
Showing with 45 additions and 15 deletions.
  1. +45 −15 src/submissions.js
View
@@ -308,6 +308,7 @@ function afcHelper_prompt(type) {
'<br /><label for="afcHelper_talkAppend">Append wikicode to talk page (optional, e.g. WikiProject templates): </label><br><textarea class="afcHelper_expand" rows="1" cols="60" id="afcHelper_talkAppend" spellcheck="true"></textarea>' +
'<br /><label for="afcHelper_reqphoto">Does the article need a photo/image? (will add &#123;&#123;<a href="'+ wgArticlePath.replace("$1", 'Template:Reqphoto') + '" title="Template:Reqphoto" target="_blank">reqphoto</a>&#125;&#125; to talk page) </label><input type="checkbox" id="afcHelper_reqphoto"/>' +
'<br /><label for="afcHelper_reqinfobox">Does the article need an infobox? (will add &#123;&#123;<a href="'+ wgArticlePath.replace("$1", 'Template:Reqinfobox') + '" title="Template:Reqinfobox" target="_blank">reqinfobox</a>&#125;&#125; to talk page) </label><input type="checkbox" id="afcHelper_reqinfobox"/>' +
'<br /><label for="afcHelper_noPatrol">Should we [[Wikipedia:Page Curation/Help|"New Page Patrol"]] this page?</label><input type="checkbox" id="afcHelper_noPatrol"/>' +
'<br /><label for="afcHelper_biography">Is the article a biography? </label><input type="checkbox" id="afcHelper_biography" onchange=afcHelper_trigger(\'afcHelper_biography_blp\') />' +
'<div id="afcHelper_biography_blp" style="display:none"><label for="afcHelper_dateofbirth">Month and day of birth (if known/given, e.g. <i>November 2</i>): </label><input type="text" id="afcHelper_dateofbirth" spellcheck="true"/>' +
'<br /><label for="afcHelper_yearofbirth">Year of birth (if known/given, e.g. <i>1901</i>): </label><input type="text" id="afcHelper_yearofbirth" />' +
@@ -351,6 +352,7 @@ function afcHelper_prompt(type) {
'<label for="afcHelper_blank">Blank the submission (replace the content with {{<a href="' + wgArticlePath.replace("$1", 'Template:Afc_cleared') + '" title="Template:Afc cleared" target="_blank">afc cleared</a>}}):</label><input type="checkbox" id="afcHelper_blank" onchange=afcHelper_trigger(\'afcHelper_afcccleared\') /><br/>' +
'<div id="afcHelper_extra_afccleared" style="display:none"><label for="afcHelper_afccleared">Trigger the \'csd\' parameter and nominate the submission for speedy deletion?</label> <input type="checkbox" id="afcHelper_blank_csd"/><br/></div>' +
'<label for="afcHelper_notify">Notify author:</label><input type="checkbox" onchange=afcHelper_trigger(\'afcHelper_notify_Teahouse\') id="afcHelper_notify" checked="checked" /><br/>' +
'<br /><label for="afcHelper_noPatrol">Should we [[Wikipedia:Page Curation/Help|"New Page Patrol"]] this page?</label><input type="checkbox" id="afcHelper_noPatrol"/>' +
'<div id="afcHelper_notify_Teahouse"><label for="afcHelper_notify_Teahouse">Notify author about <a href="' + wgArticlePath.replace("$1", 'Wikipedia:Teahouse') + '" title="Wikipedia:Teahouse" target="_blank">Wikipedia:Teahouse</a>:</label><input type="checkbox" id="afcHelper_Teahouse" /><br/></div><button type="button" class="afcHelper_button decline" id="afcHelper_prompt_button" onclick="afcHelper_act(\'decline\')">Decline</button>';
$("#afcHelper_extra").html(text);
} else if (type === 'submit') {
@@ -361,6 +363,7 @@ function afcHelper_prompt(type) {
'<input type="radio" name="afcHelper_submit" id="afcHelper_submit3" value="creator" checked /> <label for="afcHelper_submit3">submit with the page creator as the submitter</label><br>' +
'<input type="radio" name="afcHelper_submit" id="afcHelper_submit4" value="self" checked /> <label for="afcHelper_submit3">submit with yourself as the submitter</label><br>' +
'<input type="radio" name="afcHelper_submit" id="afcHelper_submit5" value="custom" /> <label for="afcHelper_submit4">submit with a custom submitter:</label> <input type="text" id="afcHelper_custom_submitter" /><br>' +
'<br /><label for="afcHelper_noPatrol">Should we [[Wikipedia:Page Curation/Help|"New Page Patrol"]] this page?</label><input type="checkbox" id="afcHelper_noPatrol"/>' +
'<button class="afcHelper_button submit" type="button" id="afcHelper_prompt_button" onclick="afcHelper_act(\'submit\')">Place a submit template</button>';
$("#afcHelper_extra").html(text);
} else if (type === 'draft') {
@@ -369,19 +372,26 @@ function afcHelper_prompt(type) {
'<input type="radio" name="afcHelper_draft" id="afcHelper_draft2" value="last" /> <label for="afcHelper_submit2">tag with the last non-bot editor as the submitter</label><br>' +
'<input type="radio" name="afcHelper_draft" id="afcHelper_draft3" value="creator" checked /> <label for="afcHelper_submit3">tag with the page creator as the submitter</label><br>' +
'<input type="radio" name="afcHelper_draft" id="afcHelper_draft4" value="custom" /> <label for="afcHelper_submit4">tag with a custom submitter:</label> <input type="text" id="afcHelper_draft_submitter" /><br>' +
'<br /><label for="afcHelper_noPatrol">Should we [[Wikipedia:Page Curation/Help|"New Page Patrol"]] this page?</label><input type="checkbox" id="afcHelper_noPatrol"/>' +
'<button class="afcHelper_button draft" type="button" id="afcHelper_prompt_button" onclick="afcHelper_act(\'draft\')">Place {{AFC draft}} template</button>';
$("#afcHelper_extra").html(text);
} else if (type === 'mark') {
var text = '<h3>Marking submission ' + afcHelper_PageName + ' as under review</h3>' +
'<label for="afcHelper_comments">Additional comment (signature is automatically added): </label><textarea rows="3" cols="60" id="afcHelper_comments" spellcheck="true"></textarea><br/><button type="button" class="afcHelper_button mark" id="afcHelper_prompt_button" onclick="afcHelper_act(\'mark\')">Place under review</button>';
'<label for="afcHelper_comments">Additional comment (signature is automatically added): </label><textarea rows="3" cols="60" id="afcHelper_comments" spellcheck="true"></textarea>' +
'<br /><label for="afcHelper_noPatrol">Should we [[Wikipedia:Page Curation/Help|"New Page Patrol"]] this page?</label><input type="checkbox" id="afcHelper_noPatrol"/>' +
'<br/><button type="button" class="afcHelper_button mark" id="afcHelper_prompt_button" onclick="afcHelper_act(\'mark\')">Place under review</button>';
$("#afcHelper_extra").html(text);
} else if (type === 'comment') {
var text = '<h3>Commenting on ' + afcHelper_PageName + ' </h3>' +
'<label for="afcHelper_comments">Comment (signature is automatically added): </label><textarea rows="3" cols="60" id="afcHelper_comments" spellcheck="true"></textarea><br/><button type="button" class="afcHelper_button comment" id="afcHelper_prompt_button" onclick="afcHelper_act(\'comment\')">Add comment</button>';
'<label for="afcHelper_comments">Comment (signature is automatically added): </label><textarea rows="3" cols="60" id="afcHelper_comments" spellcheck="true"></textarea>'+
'<br /><label for="afcHelper_noPatrol">Should we [[Wikipedia:Page Curation/Help|"New Page Patrol"]] this page?</label><input type="checkbox" id="afcHelper_noPatrol"/>' +
'<br/><button type="button" class="afcHelper_button comment" id="afcHelper_prompt_button" onclick="afcHelper_act(\'comment\')">Add comment</button>';
$("#afcHelper_extra").html(text);
} else if (type === 'postpone_g13') {
var text = '<h3>Additional comment when postponing speedy deletion</h3>' +
'<label for="afcHelper_comments">Comment (signature is automatically added): </label><textarea rows="3" cols="60" id="afcHelper_comments" spellcheck="true"></textarea><br/><button type="button" class="afcHelper_button" id="afcHelper_prompt_button" onclick="afcHelper_act(\'postpone_g13\')">Postpone G13 speedy deletion</button>';
'<label for="afcHelper_comments">Comment (signature is automatically added): </label><textarea rows="3" cols="60" id="afcHelper_comments" spellcheck="true"></textarea><br/>' +
'<br /><label for="afcHelper_noPatrol">Should we [[Wikipedia:Page Curation/Help|"New Page Patrol"]] this page?</label><input type="checkbox" id="afcHelper_noPatrol"/>' +
'<button type="button" class="afcHelper_button" id="afcHelper_prompt_button" onclick="afcHelper_act(\'postpone_g13\')">Postpone G13 speedy deletion</button>'+
$("#afcHelper_extra").html(text);
}
}
@@ -397,6 +407,7 @@ function afcHelper_act(action) {
if (action === 'draft') {
var typeofsubmit = $("input[name=afcHelper_draft]:checked").val();
var customuser = $("#afcHelper_draft_submitter").val();
var noPatrol = $("#afcHelper_noPatrol").attr("checked");
displayMessage('<ul id="afcHelper_status"></ul><ul id="afcHelper_finish"></ul>');
afcHelper_displaymessagehelper('done','standard');
if (typeofsubmit == "last") {
@@ -414,9 +425,11 @@ function afcHelper_act(action) {
}
newtext = submit + pagetext;
newtext = afcHelper_cleanup(newtext);
afcHelper_editPage(afcHelper_PageName, newtext, "Tagging [[Wikipedia:Articles for creation]] draft", false);
var doWePatrol = ( noPatrol != "checked");
afcHelper_editPage(afcHelper_PageName, newtext, "Tagging [[Wikipedia:Articles for creation]] draft", doWePatrol);
} else if (action === 'postpone_g13') {
var comment = $("#afcHelper_comments").val();
var doWePatrol = $("#afcHelper_noPatrol").attr("checked");
displayMessage('<ul id="afcHelper_status"></ul><ul id="afcHelper_finish"></ul>');
afcHelper_displaymessagehelper('done','standard');
pagetext = afcHelper_addcomment(comment) + pagetext;
@@ -433,14 +446,18 @@ function afcHelper_act(action) {
newtext = pagetext+"\n{{AfC postpone G13|1}}";
}
newtext = afcHelper_cleanup(newtext);
afcHelper_editPage(afcHelper_PageName, newtext, "Postponing [[WP:G13|G13]] speedy deletion", false);
var doWePatrol = ( noPatrol != "checked");
afcHelper_editPage(afcHelper_PageName, newtext, "Postponing [[WP:G13|G13]] speedy deletion", doWePatrol);
} else if (action === 'g13') {
displayMessage('<ul id="afcHelper_status"></ul><ul id="afcHelper_finish"></ul>');
afcHelper_displaymessagehelper('done','standard');
timestamp = afcHelper_cache.afcHelper_lastedited;
newtext = "{{Db-g13|ts=" + timestamp + "}}\n" + pagetext;
newtext = afcHelper_cleanup(newtext);
afcHelper_editPage(afcHelper_PageName, newtext, "Tagging abandoned [[Wikipedia:Articles for creation]] draft for speedy deletion under [[WP:G13|G13]]", false);
// No user options on this so we're defaulting to NOT patrol on ones we're
// G13ing in case the page gets restored in the future to give it a
// opportunity for review later
afcHelper_editPage(afcHelper_PageName, newtext, "Tagging abandoned [[Wikipedia:Articles for creation]] draft for speedy deletion under [[WP:G13|G13]]", true);
// notify users
var users = new Array();
var templates = pagetext.match(all_afc_re);
@@ -478,14 +495,16 @@ function afcHelper_act(action) {
if (typeofsubmit == 'last') {
// Get the last non-bot editor to the page
var submitinfo = afcHelper_last_nonbot(afcHelper_PageName);
var noPatrol = $("#afcHelper_noPatrol").attr("checked");
var doWePatrol = ( noPatrol != "checked");
if (submitinfo) {
dt = new Date(submitinfo['timestamp']);
// output the date in the correct format
date = dt.getUTCFullYear() + ('0' + (dt.getUTCMonth() + 1)).slice(-2) + ('0' + dt.getUTCDate()).slice(-2) + ('0' + dt.getUTCHours()).slice(-2) + ('0' + dt.getUTCMinutes()).slice(-2) + ('0' + dt.getUTCSeconds()).slice(-2);
var submit = "{{AFC submission|||ts=" + date + "|u=" + submitinfo['user'] + "|ns=" + wgNamespaceNumber + "}}\n";
newtext = submit + pagetext;
newtext = afcHelper_cleanup(newtext);
afcHelper_editPage(afcHelper_PageName, newtext, "Submitting [[Wikipedia:Articles for creation]] submission", false);
afcHelper_editPage(afcHelper_PageName, newtext, "Submitting [[Wikipedia:Articles for creation]] submission", doWePatrol);
} else {
alert("Unable to find a non-bot editor; please check the page history.");
}
@@ -534,7 +553,7 @@ function afcHelper_act(action) {
newtext = submit + pagetext
}
newtext = afcHelper_cleanup(newtext);
afcHelper_editPage(afcHelper_PageName, newtext, "Submitting [[Wikipedia:Articles for creation]] submission", false);
afcHelper_editPage(afcHelper_PageName, newtext, "Submitting [[Wikipedia:Articles for creation]] submission", doWePatrol);
}
} else if (action === 'accept') {
var newtitle = $("#afcHelper_movetarget").val();
@@ -544,6 +563,7 @@ function afcHelper_act(action) {
var talkAppend = $("#afcHelper_talkAppend").val();
var biography = $("#afcHelper_biography").attr("checked");
var reqinfobox = $("#afcHelper_reqinfobox").attr("checked");
var noPatrol = $("#afcHelper_noPatrol").attr("checked");
var reqphoto = $("#afcHelper_reqphoto").attr("checked");
var selectedwikiprojects = new Array();
@@ -716,8 +736,8 @@ function afcHelper_act(action) {
$("#afcHelper_orphan").html("Page is orphaned; adding tag.");
}
}
afcHelper_editPage(newtitle, pagetext, "Cleanup following [[Wikipedia:Articles for creation]] creation", false);
var doWePatrol = ( noPatrol != "checked");
afcHelper_editPage(newtitle, pagetext, "Cleanup following [[Wikipedia:Articles for creation]] creation", doWePatrol);
};
afcHelper_movePage(afcHelper_PageName, newtitle, 'Created via \[\[WP:AFC|Articles for creation\]\] (\[\[WP:WPAFC|you can help!\]\])', callback, true);
} else if (action === 'decline') {
@@ -732,6 +752,7 @@ function afcHelper_act(action) {
var blank_csd = $("#afcHelper_blank_csd").attr("checked");
var notify = $("#afcHelper_notify").attr("checked");
var teahouse = $("#afcHelper_Teahouse").attr("checked");
var noPatrol = $("#afcHelper_noPatrol").attr("checked");
var extra = '';
if (code === 'cv' || code === 'dup' || code === 'mergeto' || code === 'exists' || code === 'lang' || code === 'plot') {
extra = $("#afcHelper_extra_inlinebox").val();
@@ -883,9 +904,12 @@ function afcHelper_act(action) {
}
}
pagetext = afcHelper_cleanup(pagetext);
afcHelper_editPage(afcHelper_PageName, pagetext, summary, false);
var doWePatrol = ( noPatrol != "checked");
afcHelper_editPage(afcHelper_PageName, pagetext, summary, doWePatrol);
} else if (action === 'comment') {
var comment = $("#afcHelper_comments").val();
var noPatrol = $("#afcHelper_noPatrol").attr("checked");
var doWePatrol = ( noPatrol != "checked");
displayMessage('<ul id="afcHelper_status"></ul><ul id="afcHelper_finish"></ul>');
afcHelper_displaymessagehelper('done','standard');
@@ -896,9 +920,11 @@ function afcHelper_act(action) {
return;
}
pagetext = afcHelper_cleanup(pagetext);
afcHelper_editPage(afcHelper_PageName, pagetext, "Commenting on [[Wikipedia:Articles for creation]] submission", false);
afcHelper_editPage(afcHelper_PageName, pagetext, "Commenting on [[Wikipedia:Articles for creation]] submission", doWePatrol);
} else if (action === 'mark') {
var comment = $("#afcHelper_comments").val();
var noPatrol = $("#afcHelper_noPatrol").attr("checked");
var doWePatrol = ( noPatrol != "checked");
if (comment == undefined) comment = window.overwrite_comment; // This handles the overwrite_redirect scenario
displayMessage('<ul id="afcHelper_status"></ul><ul id="afcHelper_finish"></ul>');
afcHelper_displaymessagehelper('done','standard');
@@ -910,7 +936,7 @@ function afcHelper_act(action) {
pagetext = pagetext.replace(exclusive_pending_afc_re, "$1r\|\|$2\|reviewer=\{\{subst:REVISIONUSER\}\}\|reviewts={{subst:CURRENTTIMESTAMP}}\|$3");
pagetext = afcHelper_addcomment(comment) + pagetext;
pagetext = afcHelper_cleanup(pagetext);
afcHelper_editPage(afcHelper_PageName, pagetext, "Marking [[Wikipedia:Articles for creation]] submission as under review", false);
afcHelper_editPage(afcHelper_PageName, pagetext, "Marking [[Wikipedia:Articles for creation]] submission as under review", doWePatrol);
} else if (action === 'unmark') {
if (!afcHelper_underreview()) return;
displayMessage('<ul id="afcHelper_status"></ul><ul id="afcHelper_finish"></ul>');
@@ -925,15 +951,19 @@ function afcHelper_act(action) {
newtemplate = newtemplate.replace(/\|\s*reviewts=\s*([0-9]{14})[^\|]*\|/i, "");
pagetext = pagetext.replace(template, newtemplate);
pagetext = afcHelper_cleanup(pagetext);
afcHelper_editPage(afcHelper_PageName, pagetext, "Unmarking [[Wikipedia:Articles for creation]] submission as under review", false);
// No user options on this so we're defaulting to NOT patrol on ones we're
// un-marking for review to give users an opportunity to patrol it later
afcHelper_editPage(afcHelper_PageName, pagetext, "Unmarking [[Wikipedia:Articles for creation]] submission as under review", true);
} else if (action === 'cleanup') {
displayMessage('<ul id="afcHelper_status"></ul><ul id="afcHelper_finish"></ul>');
pagetext = afcHelper_cleanup(pagetext);
var text = afcHelper_getPageText(afcHelper_PageName, true, false);
if (text === pagetext) {
afcHelper_displaymessagehelper('done','cleanednochange');
} else {
afcHelper_editPage(afcHelper_PageName, pagetext, "Cleaning [[Wikipedia:Articles for creation]] submission", false);
// No user options on this so we're defaulting to NOT patrol on ones we're
// only cleaning to give users an opportunity to patrol it later
afcHelper_editPage(afcHelper_PageName, pagetext, "Cleaning [[Wikipedia:Articles for creation]] submission", true);
afcHelper_displaymessagehelper('done','standard');
}
}

6 comments on commit 1d4e958

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Mar 13, 2014

Contributor

FWIW, this will probably never be pushed to enwiki... afch-rewrite is where it's AT ;)

(If it were going to be pushed then please check indentation, haven't tested.)

Contributor

theopolisme replied Mar 13, 2014

FWIW, this will probably never be pushed to enwiki... afch-rewrite is where it's AT ;)

(If it were going to be pushed then please check indentation, haven't tested.)

@Technical-13

This comment has been minimized.

Show comment
Hide comment
@Technical-13

Technical-13 Mar 13, 2014

Contributor

I thought I said on #215 that the default would have to be to patrol and the option would be to not patrol. sigh -- I'll go through and fix this later, but I'm not happy. @hasteur if you want to add an option to the user preferences page that will allow it to be never patrol unless checking the patrol button, that is fine, but the default for those that don't change that setting should be for automatic patrolling.

Contributor

Technical-13 replied Mar 13, 2014

I thought I said on #215 that the default would have to be to patrol and the option would be to not patrol. sigh -- I'll go through and fix this later, but I'm not happy. @hasteur if you want to add an option to the user preferences page that will allow it to be never patrol unless checking the patrol button, that is fine, but the default for those that don't change that setting should be for automatic patrolling.

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Mar 13, 2014

Contributor

Before ANYTHING is even considered for pushing, beta...develop needs to be seriously cleaned up, especially stuff like beta...developdiff-c5875c2def917a84e0fc1ac19e571d81R1617 (another API call for no apparent reason).

Personally, I do not believe we should spend time maintaining or developing this repo anymore.

I think the focus should move to WPAFC/afch-rewrite, as the rewrite script is now pretty stable in its beta form and needs discussion/collaboration to determine features to add/cross-browser compatibility fixes/etc.

Contributor

theopolisme replied Mar 13, 2014

Before ANYTHING is even considered for pushing, beta...develop needs to be seriously cleaned up, especially stuff like beta...developdiff-c5875c2def917a84e0fc1ac19e571d81R1617 (another API call for no apparent reason).

Personally, I do not believe we should spend time maintaining or developing this repo anymore.

I think the focus should move to WPAFC/afch-rewrite, as the rewrite script is now pretty stable in its beta form and needs discussion/collaboration to determine features to add/cross-browser compatibility fixes/etc.

@hasteur

This comment has been minimized.

Show comment
Hide comment
@hasteur

hasteur Mar 13, 2014

Member

@Technical-13 If we aren't presenting the user any options I'm taking the viewpoint that we shouldn't be doing any unintended (sneaky) actions. I strongly object to making the AFCH tool by default patrolling for any reason, but it's as simple as adding the checked parameter to the ones where we do present the option.

I'll yank this code out of this branch this evening since we're abandoning the current development and start a branch in the rewrite to wire this logic in.

@theopolisme Perhaps you'd like to use a more narrow diff like 9ec828e to explain your frustration. Perhaps you'd like to ask the author what he was thinking when designing this. Perhaps you'd like to provide constructive suggestions rather than throw rocks and blow up the entire existing tool. Perhaps you could indicate where the text of the page was already in memory so that we didn't have to make an API call to get the text of the page. Perhaps you could see that if we don't have a AFC banner on the page, we shouldn't go through the process of determining if the page is at least 6 months unedited.

Member

hasteur replied Mar 13, 2014

@Technical-13 If we aren't presenting the user any options I'm taking the viewpoint that we shouldn't be doing any unintended (sneaky) actions. I strongly object to making the AFCH tool by default patrolling for any reason, but it's as simple as adding the checked parameter to the ones where we do present the option.

I'll yank this code out of this branch this evening since we're abandoning the current development and start a branch in the rewrite to wire this logic in.

@theopolisme Perhaps you'd like to use a more narrow diff like 9ec828e to explain your frustration. Perhaps you'd like to ask the author what he was thinking when designing this. Perhaps you'd like to provide constructive suggestions rather than throw rocks and blow up the entire existing tool. Perhaps you could indicate where the text of the page was already in memory so that we didn't have to make an API call to get the text of the page. Perhaps you could see that if we don't have a AFC banner on the page, we shouldn't go through the process of determining if the page is at least 6 months unedited.

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Mar 13, 2014

Contributor

@hasteur I thought I already commented on the diff itself; if I didn't already, my apologies.

In any case -- if my memory serves me correctly -- getPageText() doesn't have any caching mechanism, and we already get pagetext in the first function loaded, which then serves as a global. Don't quote me on that, though! In the rewrite, that was resolved by using getText( true ) -- the true tells the script to use the cached version (look at submissions.js)

Right now patrol functionality hasn't been built into the rewrite at all, although I think I added a placeholder patrol attribute to the editPage() function... let me know if you need help understanding anything in the codebase; i'm on IRC if you'd like to talk.

Contributor

theopolisme replied Mar 13, 2014

@hasteur I thought I already commented on the diff itself; if I didn't already, my apologies.

In any case -- if my memory serves me correctly -- getPageText() doesn't have any caching mechanism, and we already get pagetext in the first function loaded, which then serves as a global. Don't quote me on that, though! In the rewrite, that was resolved by using getText( true ) -- the true tells the script to use the cached version (look at submissions.js)

Right now patrol functionality hasn't been built into the rewrite at all, although I think I added a placeholder patrol attribute to the editPage() function... let me know if you need help understanding anything in the codebase; i'm on IRC if you'd like to talk.

@Technical-13

This comment has been minimized.

Show comment
Hide comment
@Technical-13

Technical-13 Mar 13, 2014

Contributor

@hasteur I'm not sure why you opened a new issue (#215) for this instead just commenting on #176 which is what implemented this six months ago, and I'm not sure why you waited so long to object. As far as it being a "sneaky" move, I disagree, patrolling requires reviewing and reviewing implies patrolling. Also, based on the requirements for getting in the "autopatrolled" usergroup, the "Draft:", "User:", and WPAFC project spaces are all out of scope for NPP which has limited itself to article space only.

Contributor

Technical-13 replied Mar 13, 2014

@hasteur I'm not sure why you opened a new issue (#215) for this instead just commenting on #176 which is what implemented this six months ago, and I'm not sure why you waited so long to object. As far as it being a "sneaky" move, I disagree, patrolling requires reviewing and reviewing implies patrolling. Also, based on the requirements for getting in the "autopatrolled" usergroup, the "Draft:", "User:", and WPAFC project spaces are all out of scope for NPP which has limited itself to article space only.

Please sign in to comment.