Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Sep 25, 2013
Theo Patt theopolisme Ignore external links to internal pages #183 accc5e3
Theo Patt theopolisme Fix major bug that broke all notifications
/me trouts @Riamse
c0415de
Theo Patt theopolisme Ignore external links to internal pages #183 0384cc6
Commits on Sep 26, 2013
Donald J. Fortier II Technical-13 Update ffu.js
Added afcdeclined to decline reasons per issue #181
9a11132
Donald J. Fortier II Technical-13 Add {{Afc postpone|n}} template when submitting drafts more than six …
…months stale.

Resolution for issue #184 after testing on testwiki.
13749d0
Theo Patt theopolisme Add input box for name of submission when declining/on-holding for AFC
…#182

Also add afcd support
8cc20ef
Commits on Sep 27, 2013
wikipedia-mabdul fix syntax error 062916c
wikipedia-mabdul some semicolons (syntax) 1482c4b
Commits on Sep 28, 2013
Donald J. Fortier II Technical-13 Update ffu.js
Clean up some AfD and AfC stuffs.
57f3762
Donald J. Fortier II Technical-13 Update ffu.js
Okay, some more work on #181 #182 & #185
749f808
Donald J. Fortier II Technical-13 Update ffu.js
This should finish it up for #181 #182 and #185
99a6c38
Theo Patt theopolisme Speed up loading of `accept` menu by getting wikiprojects asynchronously edf420f
wikipedia-mabdul regex improvements a27d289
wikipedia-mabdul Merge branch 'develop' of https://github.com/WPAFC/afch into develop e776563
wikipedia-mabdul some semicolons again 6882ffd
Theo Patt theopolisme Fix flawed logic
@Technical-13, remember, the `if` statements execute in order (and run
the *first* one that evaluates to true) -- so in your code, if
`(sub_m.holdrat == 'afd') && (sub_m.addloc)` were both true then it
would execute *that* statement, completely ignoring whether or not
`sub_m.addtl` was true, since it is only checked for in the `if`
statement below that (which never executes). Regardless, fixed. See
test edit
https://en.wikipedia.org/w/index.php?title=Wikipedia:Files_for_upload&di
ff=574868342&oldid=574863486
52c212c
Theo Patt theopolisme Display "no target given" for…submissions without a target bb8a0c2
Theo Patt theopolisme Line breaks would be nice.
@wikipedia-mabdul this was the jquery conversion too… :/
889c697
Theo Patt theopolisme Fix major AfC/R bug that caused all of the review interfaces to stack up
This would occur if the user changed their mind -- e.g., clicked
"Accept" and then "Decline." Both the accept and decline options would
be visible on screen (since the old options were never removed -- once
again the jquery conversion…)
91c51be
Theo Patt theopolisme Wrap `core.js` in an anonymous function, part of #188
This is necessary for my fix for #189
0c60eef
Theo Patt theopolisme If we're not viewing the page, don't show the review links; #189 b9dfb92
Commits on Sep 29, 2013
Theo Patt theopolisme Stop removing so many newlines
See bad
https://test.wikipedia.org/w/index.php?title=Wikipedia_talk:Articles_for
_creation/theo_sandbox&diff=180691&oldid=180690 versus good
https://test.wikipedia.org/w/index.php?title=Wikipedia_talk%3AArticles_f
or_creation%2Ftheo_sandbox&diff=180700&oldid=180699
b90b78c
Theo Patt theopolisme Display the "Done" text only after all ajax requests are completed; c…
…opyedit
439e4c8
Theo Patt theopolisme Store page statuses in afcHelper_pageStatuses; #190
Currently we utilize this list for the dynamic buttons. It still needs
to be applied to other things (for example: rather than using
pending_re, just use $.inArray('', afcHelper_pageStatuses) )
76e56c5
Theo Patt theopolisme Use afcHelper_ prefix for css class name to avoid conflicts; #191
Also remove way too broad "shadow" code (this was affecting ALL
textboxes)
85c5d32
Theo Patt theopolisme Convert to afcHelper_notice, add endquotes that were removed for some…
… reason
d5bac41
Theo Patt theopolisme Revert "Wrap `core.js` in an anonymous function" and "If we're not vi…
…ewing the page, don't show the review links"

The anonymous function messes up the globals… I knew that was too easy.
d547b12
Commits on Oct 01, 2013
Donald J. Fortier II Technical-13 Create displaymessage.js
We call this code, so we should have a local copy of it in the repo to be able to change and fix things.
cace168
Donald J. Fortier II Technical-13 Fix for #159 7427cee
Donald J. Fortier II Technical-13 Update core.js 0d7d6e6
Donald J. Fortier II Technical-13 Update submissions.js b49094b
Donald J. Fortier II Technical-13 Update submissions.js
Fix for --
[14:10:18.397] ReferenceError: assignment to undeclared variable afcHelper_authorusername @ https://en.wikipedia.org/w/index.php?action=raw&ctype=text/javascript&title=User:Theo%27s%20Little%20Bot/afch/afchelper.js/submissions.js:772
7973482
Donald J. Fortier II Technical-13 Update submissions.js 6141c71
Donald J. Fortier II Technical-13 Update submissions.js 88df702
Donald J. Fortier II Technical-13 Update submissions.js 9018896
Donald J. Fortier II Technical-13 Update submissions.js 0e8af2b
Donald J. Fortier II Technical-13 Cleaned up all "ReferenceError: assignment to undeclared variable " e… 44eac17
Donald J. Fortier II Technical-13 Fix all "SyntaxError: test for equality (==) mistyped as assignment (… 954da18
Donald J. Fortier II Technical-13 "TypeError: variable repeat redeclares argument" fixed 4555ebb
Donald J. Fortier II Technical-13 "SyntaxError: property name leprop appears more than once in object l…
…iteral" fixed

Fix for [14:38:12.151] SyntaxError: property name leprop appears more than once in object literal @ https://en.wikipedia.org/w/index.php?action=raw&ctype=text/javascript&title=User:Theo%27s%20Little%20Bot/afch/afchelper.js/submissions.js:1380
bd63573
Theo Patt theopolisme Revert "Fix all "SyntaxError: test for equality (==) mistyped as assi…
…gnment (=)?" on script load"

This reverts commit 954da18.
c88cdee
Theo Patt theopolisme Revert "Update submissions.js"
This reverts commit 7973482.
bda8609
Theo Patt theopolisme Revert "Update core.js"
This is not the page id we're talking about… look at
https://github.com/WPAFC/afch/blob/develop/src/core.js#L109 This
reverts commit 0d7d6e6.
2f127aa
Commits on Oct 05, 2013
Theo Patt theopolisme Make edit summaries more detailed #193 c48f7e0
Commits on Oct 06, 2013
Theo Patt theopolisme This is causing errors with afch_sync and afch_updater 38da358
Theo Patt theopolisme begone, erroneous editconflict messages; #194 3f23e4d
Theo Patt theopolisme Use contents of textarea if reviewer is in edit mode; #189 67a253a
Commits on Oct 07, 2013
wikipedia-mabdul adding a new cleanup rule 2ad25e2
Commits on Oct 08, 2013
Theo Patt theopolisme Add support for modern skin; #187
The modern skin does not use a bodyContent div, which was preventing
the clicks on "Review request" from triggering anything. Changed to a
more general selector.
be7bc39
Theo Patt theopolisme Use new {{{full}}} parameter with afc decline; #178 9a88eba
Theo Patt theopolisme Improve regex for afcHelper_submissionTitle
Only match ONCE at beginning of string (stops script from thinking that
the title of "Wikipedia talk:Articles for creation/test of Articles for
creation/21" is "test of 21", for example. Edge cases are fun!
c75ac6e
wikipedia-mabdul Update NPOV reason b0035fb
Theo Patt theopolisme Rather than use a list of single-element objects, combine all of a te…
…mplate's data into one object

/me gently trouts @wikipedia-mabdul for his obfuscation
14899d1
Theo Patt theopolisme Revert "Update NPOV reason"
See
https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_cr
eation/Helper_script#Small_discrepancy // This reverts commit
b0035fb.
52c36ad
Theo Patt theopolisme Handle cases when people substitute the archive top/bottom templates bd98617
Theo Patt theopolisme avoid variable conflicts 18d044e
Theo Patt theopolisme Change awkward semicolons/commas to periods; remove extraneous spaces…
… from page names
2f6a16f
Theo Patt theopolisme If no title is specified, still allow request to be reviewed; #63
Thinking about it further, I DON'T think "decline, blank" should be
preselected, as there could be more details in the request itself --
hence why I made the notice say "check the request details" :)
7d22bcd
Theo Patt theopolisme Completely revamp section parsing code
Nothing like a one liner.
6a8079b
Commits on Oct 09, 2013
Theo Patt theopolisme Ho hum, just…you know…make autoed actually work. bbcd0ea
Theo Patt theopolisme Remove non-working formatgeneral.js code
It was never being executed. Whaddya know…
34c77a2
Theo Patt theopolisme Remove apparently broken AutoEd implementation as well
importScriptURI is asynchronous, which means the code doesn't wait for
the scripts to load before continuing, resulting in reference errors
(the reason I didn't see them is becuause I had AutoEd installed
already as a userscript, so it was pre-loading it). @wikipedia-mabdul
we need to get away from importScriptURI… and this needs to be figured
out by next release.
9fe86d4
wikipedia-mabdul Cleanup: remove unneeded variable
We use now teh mwAPI
8639ca2
wikipedia-mabdul GUI: caps matters 3bb58c9
wikipedia-mabdul Bugfix: multiple times clicking on review will provide a clean interface bb47f3d
wikipedia-mabdul Feature: automatically mark redirects as declined 989b572
wikipedia-mabdul Cleanup: remove already initialized variables acef8c0
wikipedia-mabdul GUI: add links, polish design, some BRs, whitespaces, adding my code
!trout @theopolisme stop inventing the wheel when I already invented it. Leave redirects.js for me for a few weeks please
e39eaeb
Theo Patt theopolisme Revert "Cleanup: remove unneeded variable"
This reverts commit 8639ca2. ….We
still use this.
8019ac6
wikipedia-mabdul provide a test that anons don't use the script e4a3597
Theo Patt theopolisme Revert "provide a test that anons don't use the script"
[[Wikipedia:IPs are human too]]. I think I see where you're coming from
-- the result of that RFC -- but I don't want to implement anything at
this point in time without more community discussion. This reverts
commit e4a3597.
fbaf035
wikipedia-mabdul Bugfix: missed a bracket in manual merge 6955250
wikipedia-mabdul Merge branch 'develop' of https://github.com/WPAFC/afch into develop 09016bf
wikipedia-mabdul two BRs too much, removing all GUI elements when choosing (again) 'none' d910950
wikipedia-mabdul Feature: moving wikilink correction function to core.js and use it in…
… redirects.js
00c1910
Commits on Oct 10, 2013
Theo Patt theopolisme Remove random space from Flickuploadbot url 4231a7a
Commits on Oct 11, 2013
wikipedia-mabdul [[CSD:G1-12]] --> [[WP:G1-12]] d004b8c
Commits on Oct 12, 2013
Theo Patt theopolisme Fix problem where unescaped html entities could hide the rest of the …
…helper script

See
https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_cr
eation/Helper_script#Wikipedia_talk:Articles_for_creation.2FIndubious
1a173c9
Theo Patt theopolisme Fix broken AFC/R (#199) and also work on styling 0bf6126
Theo Patt theopolisme Fix more bugs with AFC/R; see #199 f4cd2da
Theo Patt theopolisme Support for defaultsort; #72 073adaa
Theo Patt theopolisme Only display comma if date is proved in persondata; fix newline behav…
…ior; reorder to match [[WP:ORDER]]
96af8c2
Theo Patt theopolisme Feature: check validity of move targets as they are typed
When accepting a submission and typing a target title, users will be
told if the title is available, if a page already exists at that title,
or, even more specifically, if the title is a redirect (and then in
turn what its target is). Uses a new `afcHelper_checkTarget()` function
and `onkeyup`.
ef73ef6
Theo Patt theopolisme Only display the Review link if the page exists; #200 310998b
Theo Patt theopolisme Fix AutoEd implementation; #197
Try running the script to see what it looks like. Note that
formatgeneral.js is still causing trouble, so I've left it commented
out.
c38dc1e
Commits on Oct 13, 2013
Theo Patt theopolisme Better error messages e5f8bc7
Commits on Oct 14, 2013
Donald J. Fortier II Technical-13 Added some console logging too to make sure that the error messages a…
…ren't getting overwritten before they can be read.
d1ad56c
Theo Patt theopolisme Revert "Added some console logging too to make sure that the error me…
…ssages aren't getting overwritten before they can be read."

`console` should NOT be used in production for numerous reasons; see
comments on reverted commit. This reverts commit
d1ad56c.
bc5f1cd
Theo Patt theopolisme Reinstate @Technical-13's console.error() with safeguard in place ab1ed06
Commits on Oct 16, 2013
Theo Patt theopolisme Re-add inadvertently removed file; #202
/me trouts himself. Sorry guys.
78d033d
Commits on Oct 17, 2013
Theo Patt theopolisme Show more of the custom decline rationale (5 words wasn't really that…
… much)
3883071
Commits on Oct 19, 2013
Theo Patt theopolisme Instructional comments shouldn't be removed until draft is accepted; #… f00efec
Theo Patt theopolisme If notify is false, don't pretend that we've notified anyone in the c…
…sd log
e909b27
Commits on Oct 23, 2013
Theo Patt theopolisme Try to clarify summaries somewhat
"Under review" seems like a better/more accurate fit, per the email
@wikipedia-mabdul forwared to me. I don't know…if you have a better
idea, I'm all ears.
ce5f9ee
Commits on Oct 31, 2013
Theo Patt theopolisme Don't output an unnecessary arrow when declining as blank or notredirect 79c4699
Commits on Nov 02, 2013
Theo Patt theopolisme Consistent css classes throughout 015a591
Theo Patt theopolisme Disable the "accept" button if the target title already exists ed7e2cf
Commits on Nov 04, 2013
Theo Patt theopolisme [cosmetic] fix spacing 278d7b2
Theo Patt theopolisme More descriptive button states per discussion in ed7e2cf
@Technical-13, please try this out and let me know your thoughts.
face781
Theo Patt theopolisme Reenable button if unable to check 4113bd5
Theo Patt theopolisme Use $.support rather than depreciated wfSupportsAjax() 3f87b47
Commits on Nov 07, 2013
Theo Patt theopolisme Fix bug where /recent would not be updated 3e6ab68
Theo Patt theopolisme Fix commenting functionality when accepting a submission ceabd97
Theo Patt theopolisme Copyedit [minor] 4e39dd3
Commits on Nov 08, 2013
Theo Patt theopolisme trim comments 4217c2d
Commits on Nov 10, 2013
Theo Patt theopolisme Switch to mw.loader rather than depreciated importScriptURI ef82979
Theo Patt theopolisme Update readme df650c6
Theo Patt theopolisme Trim inputs (see 4217c2d) c16816f
Theo Patt theopolisme New beta release (10 November 2013) 13ea0a0