Faulty CSD trigger for copyvio declines #137

Closed
Technical-13 opened this Issue Aug 29, 2013 · 5 comments

Comments

Projects
None yet
2 participants
Contributor

Technical-13 commented Aug 29, 2013

Whenever I decline a submission as a copyvio, I hit the ''Trigger the 'csd' parameter and nominate the submission for CSD?'' checkbox. However, this doesn't actually tag the page with a CSD template, just the {{t|afc cleared}} one without the CSD parameter. Here's a {{diff2|570714101|recent example}}. [[User:Deadbeef|Dea]][[User Talk:Deadbeef|db]][[Special:Contributions/Deadbeef|eef]] 19:47, 29 August 2013 (UTC)

  • Now that we have the ability to tag files for deletion and log that to the user's Twinkle CSD log, logging should be added to these as well. {{U|Deadbeef}}, I'll put in a ticket on GitHub for you tonight and for the logging as well. Thanks for your report! :) [[User:Technical 13|Technical 13]]([[User talk:Technical 13|talk]]) 20:12, 29 August 2013 (UTC)

::Thanks for the quick action/reply! [[User:Deadbeef|Dea]][[User Talk:Deadbeef|db]][[Special:Contributions/Deadbeef|eef]] 20:14, 29 August 2013 (UTC)

The other ticket I mentioned I'd put in is #136

Contributor

theopolisme commented Aug 29, 2013

Okay, this is the correct functionality; {{afc cleared|csd}} transcludes {{db-decline}}, which adds the submission to the CSD category. But it appears there is some bug somewhere... Update: I see what the issue is. Fixing.

Contributor

theopolisme commented Aug 30, 2013

Bug fix basically done, just need to test and will push later today--

Contributor

Technical-13 commented Aug 30, 2013

I think his problem specifically was "just the {{t|afc cleared}} one without the CSD parameter." it was passing {{afc cleared}} and not {{afc cleared|csd}}. @theopolisme

Contributor

theopolisme commented Aug 30, 2013

Yes

theopolisme added a commit that referenced this issue Aug 30, 2013

Contributor

theopolisme commented Aug 30, 2013

The issue should be resolved. @Technical-13, if you'd like to pass the message on to Deadbeef onwiki (and also invite him to test it out using the theobot mirror), that'd be great... then please close this issue (or rather, mark it as to be pushed, or working on, or whatever you unilaterally decided..)

theopolisme added a commit that referenced this issue Aug 30, 2013

@Technical-13 Technical-13 reopened this Sep 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment