New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All <input type="text"> fields should have spellchecker enabled. #159

Closed
Technical-13 opened this Issue Sep 7, 2013 · 12 comments

Comments

@Technical-13
Contributor

Technical-13 commented Sep 7, 2013

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input

spellcheck HTML5
Setting the value of this attribute to true indicates that the element needs to have its spelling and grammar checked. The value default indicates that the element is to act according to a default behavior, possibly based on the parent element's own spellcheck value. The value false indicates that the element should not be checked.

@wikipedia-mabdul

This comment has been minimized.

Show comment
Hide comment
@wikipedia-mabdul

wikipedia-mabdul Sep 7, 2013

Member

If i read the spec correctly, either we add everywhere spellcheck = yes and spellcheck = no or we should simply ignore that as yes is the defacto state which is enabled. Or am i missing something? Do we need to turn it on explicit, although the browser does it?

Member

wikipedia-mabdul commented Sep 7, 2013

If i read the spec correctly, either we add everywhere spellcheck = yes and spellcheck = no or we should simply ignore that as yes is the defacto state which is enabled. Or am i missing something? Do we need to turn it on explicit, although the browser does it?

@Technical-13

This comment has been minimized.

Show comment
Hide comment
@Technical-13

Technical-13 Sep 7, 2013

Contributor

Firefox 23 doesn't turn it on by default... I think it should be done explicitly for each input unless we can do it once for the whole form and have it take.

Contributor

Technical-13 commented Sep 7, 2013

Firefox 23 doesn't turn it on by default... I think it should be done explicitly for each input unless we can do it once for the whole form and have it take.

@wikipedia-mabdul

This comment has been minimized.

Show comment
Hide comment
@wikipedia-mabdul

wikipedia-mabdul Sep 8, 2013

Member

alright, firefox again. XD

Member

wikipedia-mabdul commented Sep 8, 2013

alright, firefox again. XD

@wikipedia-mabdul

This comment has been minimized.

Show comment
Hide comment
@wikipedia-mabdul

wikipedia-mabdul Sep 8, 2013

Member

pushed with wrong edit summary XD

Member

wikipedia-mabdul commented Sep 8, 2013

pushed with wrong edit summary XD

@wikipedia-mabdul

This comment has been minimized.

Show comment
Hide comment
@wikipedia-mabdul

wikipedia-mabdul Sep 8, 2013

Member

btw: we should add type number as mentioned at http://w3schools.com/html/html5_form_input_types.asp

Member

wikipedia-mabdul commented Sep 8, 2013

btw: we should add type number as mentioned at http://w3schools.com/html/html5_form_input_types.asp

@Technical-13

This comment has been minimized.

Show comment
Hide comment
@Technical-13

Technical-13 Sep 8, 2013

Contributor

number for what @wikipedia-mabdul ???

Contributor

Technical-13 commented Sep 8, 2013

number for what @wikipedia-mabdul ???

@wikipedia-mabdul

This comment has been minimized.

Show comment
Hide comment
@wikipedia-mabdul

wikipedia-mabdul Sep 8, 2013

Member

the year field for biographical accepted articles. (dunno how is the input for the persondata field if the person lived before the year 0?)

Member

wikipedia-mabdul commented Sep 8, 2013

the year field for biographical accepted articles. (dunno how is the input for the persondata field if the person lived before the year 0?)

@wikipedia-mabdul

This comment has been minimized.

Show comment
Hide comment
@wikipedia-mabdul

wikipedia-mabdul Sep 9, 2013

Member

ok, checking the examples at https://en.wikipedia.org/wiki/Wikipedia:PERSONDATA#Examples this is actually not very wise. so we have no need for that as I checked all other input fields.

this can so be closed when pushed to live data. (except I missed an text / input field)

Member

wikipedia-mabdul commented Sep 9, 2013

ok, checking the examples at https://en.wikipedia.org/wiki/Wikipedia:PERSONDATA#Examples this is actually not very wise. so we have no need for that as I checked all other input fields.

this can so be closed when pushed to live data. (except I missed an text / input field)

@Technical-13

This comment has been minimized.

Show comment
Hide comment
@Technical-13

Technical-13 Sep 9, 2013

Contributor

Are you saying that defining that field as a number is not a wise idea or enabling spell-checker for all of the fields isn't wise?

Contributor

Technical-13 commented Sep 9, 2013

Are you saying that defining that field as a number is not a wise idea or enabling spell-checker for all of the fields isn't wise?

@wikipedia-mabdul

This comment has been minimized.

Show comment
Hide comment
@wikipedia-mabdul

wikipedia-mabdul Sep 9, 2013

Member

defining any field as number field as we don't have any field which is a plain number.

spell-checker is just fine and a very good improvement for staying up to date with the new browser improvements.

Member

wikipedia-mabdul commented Sep 9, 2013

defining any field as number field as we don't have any field which is a plain number.

spell-checker is just fine and a very good improvement for staying up to date with the new browser improvements.

@Technical-13

This comment has been minimized.

Show comment
Hide comment
@Technical-13

Technical-13 Oct 1, 2013

Contributor

This was not set into place globally... Once GitHub comes back up from having DB issues, I'll add this myself.
See https://en.wikipedia.org/wiki/User_talk:Timotheus_Canens/displaymessage.js#Edit_Request_October_1.2C_2013_by_Technical_13

Contributor

Technical-13 commented Oct 1, 2013

This was not set into place globally... Once GitHub comes back up from having DB issues, I'll add this myself.
See https://en.wikipedia.org/wiki/User_talk:Timotheus_Canens/displaymessage.js#Edit_Request_October_1.2C_2013_by_Technical_13

@Technical-13 Technical-13 reopened this Oct 1, 2013

@ghost ghost assigned Technical-13 Oct 1, 2013

Technical-13 added a commit that referenced this issue Oct 1, 2013

@theopolisme

This comment has been minimized.

Show comment
Hide comment
@theopolisme

theopolisme Oct 6, 2013

Contributor

Reverted, wontfixed.

Contributor

theopolisme commented Oct 6, 2013

Reverted, wontfixed.

@theopolisme theopolisme closed this Oct 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment