New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Patrol Page" functionality #215

Open
hasteur opened this Issue Mar 12, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@hasteur
Member

hasteur commented Mar 12, 2014

In order to make sure that the checks and balances between New Page Patrol and Articles for Creation remain even, we should disable the code that does the "Patrol Page" functionality that can occur from any edit that changes a AFCH eligible page.

AFC checks for one set of criteria, whereas NPP is checking for a different set. Even if a editor is cleaning a AFC submission, if the "Patrol Page" link is available, the helper is marking the page as approved.

"given enough eyeballs, all bugs are shallow" - Linus's Law

@hasteur hasteur self-assigned this Mar 12, 2014

@hasteur

This comment has been minimized.

Member

hasteur commented Mar 12, 2014

Giving 48 hours for feedback before I code in the change

@theopolisme

This comment has been minimized.

Contributor

theopolisme commented Mar 12, 2014

@Technical-13, comments as original suggester of this feature?

@Technical-13

This comment has been minimized.

Contributor

Technical-13 commented Mar 12, 2014

Yeah, I oppose reverting this change. Everyone keeps telling me that NPP is terribly backlogged and mostly intended to make sure that edits to article space are reasonable. AfC drafts are not (and should never be) in article space unless they have been read and approved which eliminates the need for a NPP reviewer to look them over anyway.

@hasteur

This comment has been minimized.

Member

hasteur commented Mar 12, 2014

So the wisdom of 25 volunteers substitutes for the wisdom of hundreds of volunteers and the backing of WMF? The new page triage looks for different items in addition to a random sampling of afc volunteers believing that the npp catch net is below us?

I reiterate my assertion that the arch tool should not patrol at all and especially in cases of declines/cleans/comments.

Sent from my iPhone

On Mar 12, 2014, at 3:46 PM, "Donald J. Fortier II" notifications@github.com wrote:

Yeah, I oppose reverting this change. Everyone keeps telling me that NPP is terribly backlogged and mostly intended to make sure that edits to article space are reasonable. AfC drafts are not (and should never be) in article space unless they have been read and approved which eliminates the need for a NPP reviewer to look them over anyway.


Reply to this email directly or view it on GitHub.

@hasteur

This comment has been minimized.

Member

hasteur commented Mar 12, 2014

Npp is no more back logged than afc in addition to having hundreds of volunteers instead of the paltry 25 active reviewers here

Sent from my iPhone

On Mar 12, 2014, at 3:46 PM, "Donald J. Fortier II" notifications@github.com wrote:

Yeah, I oppose reverting this change. Everyone keeps telling me that NPP is terribly backlogged and mostly intended to make sure that edits to article space are reasonable. AfC drafts are not (and should never be) in article space unless they have been read and approved which eliminates the need for a NPP reviewer to look them over anyway.


Reply to this email directly or view it on GitHub.

@Technical-13

This comment has been minimized.

Contributor

Technical-13 commented Mar 13, 2014

I would support a "reviewer option" to disable patrolling of draft upon review, if that is something you want to code up. However, since we are technically "reviewing" these drafts, they should be marked as reviewed/patrolled. If you want to add a checkbox to the review form that will allow the reviewers to not patrol a specific submission for what-ever reason, go for it, but it needs to be patrolled by default.

Technical-13 referenced this issue Mar 13, 2014

Add User input option to every page affecting change.
In cases where there is no user input we default to not patrol.
Supports issue 215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment