1880 Update INN_* constants #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdarby
added
status: needs review
type: tech debt
|
If those constants are not used anywhere in the theme, wouldn't it make more sense to remove them from the theme outright, only adding them to child themes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes the following changes:
INN_MEMBERconstant and its referencesINN_HOSTEDconstant toWPB_HOSTEDWhy
For #1880
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
changelog.mdfile been updated to reflect the updates in this PR?inn_logoand styling to go along with it. Should we remove that in this PR or a separate one?