New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some emoji images are missing #20

Closed
jahvi opened this Issue Feb 1, 2014 · 13 comments

Comments

Projects
None yet
4 participants
@jahvi
Copy link
Contributor

jahvi commented Feb 1, 2014

Some emojis like lantern and package are missing from the image folder, I haven't been able to check in depth but there could be more.

@cfoellmann

This comment has been minimized.

Copy link
Member

cfoellmann commented Feb 1, 2014

Are These in the library we use? Or did I screw up?
We can check the autocomplete repo for missing images. But I am not sure if the size is ok

@jahvi

This comment has been minimized.

Copy link
Contributor

jahvi commented Feb 1, 2014

No they're missing from the library we're using, I think ideally we should just use a sprite like this one but for now we could just try to find the missing images and save them separately.

@cfoellmann

This comment has been minimized.

Copy link
Member

cfoellmann commented Feb 1, 2014

Since there is no standard for emoji we could look at what is used the most. Like this listing: http://www.emoji-cheat-sheet.com/ + https://github.com/arvida/emoji-cheat-sheet.com
Other resources: https://api.github.com/emojis + http://developer.github.com/v3/emojis/ + https://github.com/github/gemoji

@jahvi

This comment has been minimized.

Copy link
Contributor

jahvi commented Feb 1, 2014

GitHub's emoji api looks really nice, we could even load the images from
their servers and reduce the plugin's size.
On Feb 1, 2014 6:21 PM, "Christian Foellmann" notifications@github.com
wrote:

Since there is no standard for emoji we could look at what is used the
most. Like this listing: http://www.emoji-cheat-sheet.com/ +
https://github.com/arvida/emoji-cheat-sheet.com
Other resources: https://api.github.com/emojis +
http://developer.github.com/v3/emojis/ + https://github.com/github/gemoji

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-33885901
.

@cfoellmann

This comment has been minimized.

Copy link
Member

cfoellmann commented Feb 1, 2014

That could be an opt-in option. External loading is sometimes problematic. Even loading Open Sans via Google Fonts API in WP 3.8+ is controversial

@jahvi

This comment has been minimized.

Copy link
Contributor

jahvi commented Feb 1, 2014

I agree we could just save the missing images for now then.
On Feb 1, 2014 7:05 PM, "Christian Foellmann" notifications@github.com
wrote:

That could be an opt-in option. External loading is sometimes problematic.
Even loading Open Sans via Google Fonts API in WP 3.8+ is controversial

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-33886880
.

@yoren

This comment has been minimized.

Copy link
Member

yoren commented Feb 2, 2014

We have 884 emojies defined in admin.js, and there are only 847 PNGs comes with jqeury-emoji.

My suggestion:

  1. Add an "images" folder in the plugin root directory.
  2. Add the complete PNGs into "images"
  3. Remove images folder from the "lib" folder, since the jquery-emoji doesn't load the PNGs from itself.
  4. Change images path in js files accordingly.
@jahvi

This comment has been minimized.

Copy link
Contributor

jahvi commented Feb 3, 2014

I agree with @yoren jquery-emoji loads the images using github anyways so I'm not sure why they even include them with the plugin (maybe they're planning to add local loading)

I just pushed the frontend emoji rendering functionality with a506b28, but we should change the folder location.

@cfoellmann

This comment has been minimized.

Copy link
Member

cfoellmann commented Feb 3, 2014

I recommend to change the script and load the pngs from the <root>/images/folder. We need to select a full set of emojis and then make sure we have all images locally and (if we want to go for it) a "cdn" (online) location we can reference.
We need to make sure that all emojis we support are available in both locations. GitHub emoji API currently supports 888 emojis.

@yoren

This comment has been minimized.

Copy link
Member

yoren commented Feb 3, 2014

I'll deal with images and change the path in js or css accordingly.

UPDATE: Github emoji API has 887 emojis.

@yoren

This comment has been minimized.

Copy link
Member

yoren commented Feb 3, 2014

I've confirmed there should be 884 emojies for now. Github lists 887 but 3 of them are missing (image files not found): flipper, loud_sound, night_with_stars.

@yoren

This comment has been minimized.

Copy link
Member

yoren commented Feb 10, 2014

I filed a report to GitHub on Saturday, it turned out they didn't notice the missing 3 emojis, maybe we'll get the full set soon.

@slobodan

This comment has been minimized.

Copy link
Contributor

slobodan commented Feb 10, 2014

Wow, this is nice, you're fixing GitHub :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment