Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pm field permissions #861

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix pm field permissions #861

merged 3 commits into from
Aug 1, 2024

Conversation

alextannenbaum
Copy link
Member

@alextannenbaum alextannenbaum commented Aug 1, 2024 •
edited by benjamin-antupit
Loading

IT WAS MISSING A FUCKING ,
I SWEAR TO GOD
THANK YOU BENJAMIN FOR YOUR HELP <3

benjamin-antupit
benjamin-antupit approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@benjamin-antupit benjamin-antupit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was such an expensive issue to fix. Lgtm.

@alextannenbaum
Copy link
Member Author

alextannenbaum commented Aug 1, 2024 •
edited by benjamin-antupit
Loading

This took me 6 hours and benjamin 1.5 hours to fix
This took at least 7.5 hours of person time, which is 7.5 hours too many.

@alextannenbaum alextannenbaum merged commit 7e34ef0 into master Aug 1, 2024
1 check passed
@i-am-gizm0
Copy link

🚀 🎉

@benjamin-antupit benjamin-antupit deleted the fix-pm-field-permissions branch August 1, 2024 00:44
@coveralls
Copy link

coveralls commented Aug 1, 2024 •
edited
Loading

Coverage Status

coverage: 91.077%. remained the same
when pulling dfa6fac on fix-pm-field-permissions
into 21a089a on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamin-antupit benjamin-antupit benjamin-antupit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alextannenbaum @i-am-gizm0 @coveralls @benjamin-antupit