Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Rewards PyBullet Independance #35

Merged
merged 14 commits into from
Jan 14, 2021

Conversation

goobta
Copy link
Member

@goobta goobta commented Dec 17, 2020

Closes #34.

Dependent upon #33 and #32 cause of the big rename and adding more rewards, so those should probably be merged in first. This should just work once it's merged in though.

@goobta goobta added bug Something isn't working cleanliness refactoring the code to make it more elegant labels Dec 17, 2020
@coveralls
Copy link

coveralls commented Dec 17, 2020

Pull Request Test Coverage Report for Build 486381502

  • 110 of 111 (99.1%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.263%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gym_solo/core/test_rewards.py 81 82 98.78%
Totals Coverage Status
Change from base Build 406391266: 0.2%
Covered Lines: 792
Relevant Lines: 806

💛 - Coveralls

examples/solo8_vanilla/observation_dump.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Outdated Show resolved Hide resolved
Copy link
Member Author

@goobta goobta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replies attached.

examples/solo8_vanilla/observation_dump.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More questions for you

examples/solo8_vanilla/observation_dump.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (See how I did not use a short form)

examples/solo8_vanilla/observation_dump.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Show resolved Hide resolved
gym_solo/core/rewards.py Outdated Show resolved Hide resolved
@goobta goobta merged commit 454bed3 into master Jan 14, 2021
@goobta goobta deleted the agupta231-rewards-unique-client branch January 14, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanliness refactoring the code to make it more elegant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Rewards Environment Independant
3 participants