Fast Foward Gym Solo #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goobta
added
bug
Pull Request Test Coverage Report for Build 649393226
💛 - Coveralls |
goobta
commented
Mar 13, 2021
mahajanrevant
approved these changes
Mar 20, 2021
|
|
||
| while True: | ||
| pos = float(input('Which position do you want to set all the joints to?: ')) | ||
| if pos == 69.: |
There was a problem hiding this comment.
What is up with this xD?
There was a problem hiding this comment.
oh that's the value to reset the robot lol. I'll open up another PR and get rid of it lmfao
|
Why do we have solo8_mmr now? |
|
We realistically only have 2 versions: ODRI's Solo and ours. Since we aren't really tracking revisions, I figured it's probably easier just to make a unified name rather than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda of a huge PR, sorry for the bulk. tl;dr:
gym_solo/assetsis now a submodule to https://github.com/WPI-MMR/assets. We can use that repo for issue tracking and everything will get updated here as wellI'll also add comments in the PR as well to help explain some of my logic and reasoning.