Fix lack of URL decoding when deploying #437
2 participants
|
ThomasJClark |
Some checks were not successful |
02c4a21
|
ui/src/main/java/edu/wpi/grip/ui/DeployController.java
| @@ -160,7 +162,8 @@ private void deploy(String address, String user, String password, String javaHom | ||
| setStatusAsync("Running GRIP", false); | ||
| Session session = ssh.startSession(); | ||
| session.allocateDefaultPTY(); | ||
| - Session.Command cmd = session.exec(javaHome + "/bin/java -jar " + deployDir + "/" + GRIP_JAR + " " + deployDir + "/" + PROJECT_FILE); | ||
| + Session.Command cmd = session.exec(javaHome + "/bin/java -jar " + deployDir + "/" + GRIP_JAR + "' '" | ||
| + + deployDir + "/" + PROJECT_FILE + "'"); |
JLLeitschuh
Shouldn't we support uploading multiple project files and allowing the user to pick which one that they want to use? |
2 of 5 checks passed
codecov/patch
CI failed: coverage not measured fully.
Details
codecov/project
CI failed: coverage not measured fully.
Details
continuous-integration/appveyor/pr
AppVeyor build cancelled
Details
codacy/pr
Good work! The project quality is stable.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was causing problems when the full path of the local GRIP jar has spaces in it.
Closes #435