Skip to content

Conversation

JaciBrunning
Copy link
Member

This PR will close #428 upon merging

@codecov-io
Copy link

Current coverage is 51.74%

Merging #438 into master will decrease coverage by -0.05% as of 06714a2

@@            master    #438   diff @@
======================================
  Files          122     122       
  Stmts         3614    3614       
  Branches       415     415       
  Methods          0       0       
======================================
- Hit           1872    1870     -2
- Partial        117     118     +1
- Missed        1625    1626     +1

Review entire Coverage Diff as of 06714a2


Uncovered Suggestions

  1. +0.58% via .../ExceptionAlert.java#83...103
  2. +0.41% via ...cketPreviewView.java#90...104
  3. +0.39% via ...cketPreviewView.java#38...51
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

build.gradle Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this equivalent to def os = osdetector.classifier.replace("osx", "macosx").replace("x86_32", "x86")?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair note

@JLLeitschuh
Copy link
Member

Thanks!

ThomasJClark added a commit that referenced this pull request Jan 27, 2016
Fix OS 32-bit artifact fetching
@ThomasJClark ThomasJClark merged commit 201dcbb into WPIRoboticsProjects:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build in ubuntu 32bit fail

4 participants