/GRIP

Fix OS 32-bit artifact fetching #438

Merged
merged 2 commits into from Jan 27, 2016

Reviewers

No reviews

Assignees

No one assigned

Labels

Looks Good To Me! (DEV Approval)

Projects

None yet

Milestone

No milestone

4 participants

@JacisNonsense @codecov-io @JLLeitschuh @ThomasJClark
@JacisNonsense
Member
JacisNonsense commented Jan 26, 2016

This PR will close #428 upon merging
@JacisNonsense JacisNonsense Fix OS 32-bit artifact fetching

Some checks were not successful

1 errored and 3 successful checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
codecov/patch — coverage not affected
Details
codecov/project — 51.74% (offset) compared to ccccf5f at 51.79%
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
4386a5e
@codecov-io
codecov-io commented Jan 26, 2016

Current coverage is 51.74%

Merging #438 into master will decrease coverage by -0.05% as of 06714a2

@@            master    #438   diff @@
======================================
  Files          122     122       
  Stmts         3614    3614       
  Branches       415     415       
  Methods          0       0       
======================================
- Hit           1872    1870     -2
- Partial        117     118     +1
- Missed        1625    1626     +1

Review entire Coverage Diff as of 06714a2

Uncovered Suggestions

  1. +0.58% via .../ExceptionAlert.java#83...103
  2. +0.41% via ...cketPreviewView.java#90...104
  3. +0.39% via ...cketPreviewView.java#38...51
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.
@ThomasJClark ThomasJClark and 1 other commented on an outdated diff Jan 26, 2016
View full outdated diff
build.gradle
@@ -76,7 +76,7 @@ allprojects {
}
}
-def os = osdetector.classifier.replace("osx", "macosx").replace("windows-x86_32", "windows-x86")
+def os = osdetector.classifier.replace("osx", "macosx").replace("windows-x86_32", "windows-x86").replace("x86_32", "x86")
@ThomasJClark
ThomasJClark Jan 26, 2016 Contributor

Isn't this equivalent to def os = osdetector.classifier.replace("osx", "macosx").replace("x86_32", "x86")?

@JacisNonsense
JacisNonsense Jan 26, 2016 Member

Fair note
@JacisNonsense JacisNonsense Shorten

All checks have passed

5 successful checks
codacy/pr — Good work! The project quality is stable.
Details
codecov/patch — coverage not affected
Details
codecov/project — 51.74% (offset) compared to ccccf5f at 51.79%
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
f82d1e4
@JLLeitschuh
Member
JLLeitschuh commented Jan 26, 2016

Thanks!
@ThomasJClark ThomasJClark merged commit 201dcbb into WPIRoboticsProjects:master Jan 27, 2016
5 checks passed

5 checks passed

codacy/pr Good work! The project quality is stable.
Details
codecov/patch coverage not affected
Details
codecov/project 51.74% (offset) compared to ccccf5f at 51.79%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment