Add command line parsing in GUI mode and headless Windows support #498
3 participants
codecov-io
commented
Feb 12, 2016
Current coverage is
|
|
ThomasJClark |
Some checks were not successful |
5757d17
|
core/src/main/java/edu/wpi/grip/core/Main.java
| @SuppressWarnings("PMD.SystemPrintln") | ||
| public static void main(String[] args) throws IOException, InterruptedException { | ||
| - // Close GRIP when we get SIGHUP. This signal is sent, for example, when GRIP is run in an SSH session | ||
| - // and the session is closed. | ||
| - Signal.handle(new Signal("HUP"), signal -> SafeShutdown.exit(0)); | ||
| - | ||
| - System.out.println("Loading Dependency Injection Framework"); |
|
|
core/src/main/java/edu/wpi/grip/core/Main.java
| @SuppressWarnings("PMD.SystemPrintln") | ||
| public static void main(String[] args) throws IOException, InterruptedException { | ||
| - // Close GRIP when we get SIGHUP. This signal is sent, for example, when GRIP is run in an SSH session | ||
| - // and the session is closed. | ||
| - Signal.handle(new Signal("HUP"), signal -> SafeShutdown.exit(0)); |
JLLeitschuh
Now GRIP on a remote device will continue to publish after you disconnect. 
ThomasJClark
Why is that bad? If you're testing robot code and deploying new GRIP stuff, I don't understand why you would want it to stop when you're disconnected. The reason we used to do that was to avoid letting multiple GRIPs run at the same time, but that's not a problem anymore with the wrapper script |
2 of 5 checks passed
codacy/pr
Not so good... This pull request quality could be better.
Details
codecov/patch
0.00% of diff hit (target 70.00%)
Details
codecov/project
50.30% (-0.04%) compared to 05bb96e at 50.34%
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In GUI mode, a file name can be specified to open, and --headless can be
added to the command to make it not really open the GUI.
In headless mode, we don't really need to listen for hangup signals
(since the wrapper script will kill any old instances of GRIP), so we
can remove that to make it work on non-unix systems.
Closes #493
Closes #492