Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download chart to waterfall? #1320

Closed
bazzadp opened this issue Dec 24, 2019 · 2 comments
Closed

Add download chart to waterfall? #1320

bazzadp opened this issue Dec 24, 2019 · 2 comments

Comments

@bazzadp
Copy link
Contributor

@bazzadp bazzadp commented Dec 24, 2019

Have you ever thought about adding a download chart, similar to the "Browser Main Thread" or "Page is interactive" charts? I thought it used to have something like this but maybe I imagined it...

This would show the amount being downloaded across all connections - and more importantly where there are large gaps when nothing is being downloaded (because it's waiting on connection establishment, or back end processing, or JavaScript is executing to give next set of assets...etc.).

Ideally it would be a percentage of available bandwidth but that might be quite complicated to estimate, so maybe percentage of maximum download. e.g. at one point 6 connections downloaded 50 kbps and that was maximum so that's your top Y gradient, and 0 is your bottom, so then measure everything based off of that.

Thoughts?

@pmeenan

This comment has been minimized.

Copy link
Contributor

@pmeenan pmeenan commented Dec 24, 2019

image

It's already there ("Bandwidth"). For tests with pre-configured connectivity it is capped at the configured bandwidth, otherwise it estimates it based on the peak data.

Screen Shot 2019-12-24 at 11 29 12 AM

It should be there by default for all desktop agents (including mobile emulation). For mobile devices you need to enable tcpdump capture to get it (bonus, for the tcpdump version, it shows goodput and spurious retransmits):

Screen Shot 2019-12-24 at 11 51 16 AM

The timings might not align perfectly with the waterfall but they should be close.

@bazzadp

This comment has been minimized.

Copy link
Contributor Author

@bazzadp bazzadp commented Dec 24, 2019

Thanks @pmeenan - I knew I’d seen it before. Need to get used to living in this mobile first world 😀

@bazzadp bazzadp closed this Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.