New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate string search #6

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@amiyagupta
Copy link

amiyagupta commented Mar 30, 2018

The indexOf call which is used to filter out any traffic to the local server takes about 20% of CPU time on the main thread in the latest version of the exe: see flame graph.

For some reason I never seemed to hit a string match with the filtering code, even running the version of the exe from Jan 6 when the indexOf call was initially added. The only time I got a match was when I explicitly loaded up a url starting with http://127.0.0.1:8888 in Edge.

As an extra precaution I added PID filtering which should be much cheaper than running string matching. This would still miss traffic from other processes running on the agent that call the local server. I just haven't seen any such traffic but if we know the names of any such processes, they could be filtered out in a similar fashion.

Let me know if you have a way to reproduce the local traffic issue and I'd be happy to add a cheaper way to filter it out.

@pmeenan

This comment has been minimized.

Copy link
Contributor

pmeenan commented Mar 30, 2018

@pmeenan

This comment has been minimized.

Copy link
Contributor

pmeenan commented Mar 31, 2018

I removed it.

@pmeenan pmeenan closed this Mar 31, 2018

@amiyagupta amiyagupta deleted the amiyagupta:eliminate-string-search branch Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment