Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hero element times by default #249

Closed

Conversation

Projects
None yet
2 participants
@wildlyinaccurate
Copy link
Contributor

commented Mar 20, 2019

Accompanying PR for WPO-Foundation/webpagetest#1261

@wildlyinaccurate wildlyinaccurate force-pushed the wildlyinaccurate:master branch from d38f4eb to 8791b07 Mar 20, 2019

@pmeenan

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

I'm hesitant to make it force-enabled in the agent. My preference would be to control it with a config on the server (which I will enable by default on the public instance) and then have the agent honor the server's request. At least until we can assess the overhead. It should be minor but any overhead can be pretty detrimental to something like the HTTP Archive agents.

@wildlyinaccurate

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Good call! I'll move it to a config on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.