Add rule to disallow alternative PHP open tags. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
added
issue: input/decision needed
pr: wait for upstream
approved / in handbook
and removed
issue: input/decision needed
labels
grappler
force-pushed
the
feature/theme-review-sniffs
branch
from
b8a5e09
to
5dd4758
Compare
grappler
force-pushed
the
WPTRT/feature/issue-15-no-alternative-php-open-tags
branch
from
fea0932
to
3063328
Compare
jrfnl
force-pushed
the
WPTRT/feature/issue-15-no-alternative-php-open-tags
branch
2 times, most recently
from
c5c59b8
to
dd7655f
Compare
|
Upstream PR WordPress/WordPress-Coding-Standards#585 has been merged, so once we update the There is also still an upstream PR at PHPCS for this squizlabs/PHP_CodeSniffer#1084, so at a later point in time, we might be able to swop them out. |
grappler
force-pushed
the
feature/theme-review-sniffs
branch
2 times, most recently
from
563cd1d
to
6671823
Compare
jrfnl
force-pushed
the
WPTRT/feature/issue-15-no-alternative-php-open-tags
branch
from
dd7655f
to
00cf723
Compare
grappler
deleted the
WPTRT/feature/issue-15-no-alternative-php-open-tags
branch
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the action item from #15 if the decision requested would follow the advice given.