Extend message to check for non-minified version #102

Merged
merged 1 commit into from Jan 3, 2017

Projects

None yet

2 participants

@grappler

No description provided.

@grappler grappler self-assigned this Dec 30, 2016
@grappler grappler requested a review from jrfnl Dec 30, 2016
@jrfnl
jrfnl commented Dec 30, 2016

General question: as this uses a PHPCS "Internal" check, I wonder if we can rely on these type of checks to always be available or if there is a chance that they can be removed/renamed without notice (ok, well a little notice buried somewhere deep in a changelog)

I seem to remember there is another one somewhere in TRTCS as well (or in a branch in progress).

I feel we need to verify whether Internal checks can be used in rulesets with the PHPCS project before we start including them.

@grappler

The other one that we have is changes the mixed line endings to error instead of warning.

As PHPCS 3.0 is going to be released soon I don't expect any major changes to PHPCS 2.0 so we should be good. If they were to be removed it would not be the end of the world.

@jrfnl
jrfnl commented Dec 30, 2016 edited

I would still like to verify the PHPCS stance on usage of these, so that at least we know their view on this.

@jrfnl
jrfnl commented Jan 3, 2017

@grappler Awesome!

TL;DR: squizlabs/PHP_CodeSniffer#1256 confirms that it is ok to use internal codes in rulesets.

Hereby documented in case of future questions.

@jrfnl
jrfnl approved these changes Jan 3, 2017 View changes
@jrfnl jrfnl merged commit af4f83d into feature/theme-review-sniffs Jan 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jrfnl jrfnl deleted the feature/minified-files branch Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment