Split JS Code & new modes #4

Merged
merged 3 commits into from Feb 21, 2012

Conversation

Projects
None yet
2 participants
@wieczo
Contributor

wieczo commented Feb 19, 2012

Hello!

I've moved the JavaScript code in separate JS files to make it easier to read. The html_tags var containing the auto-complete tags is in html-tags.js which makes the code easier to inspect.

I've added JS & CSS modes. It inspects the file extension and loads the modes for css, js & php files.

@wieczo

This comment has been minimized.

Show comment
Hide comment
@wieczo

wieczo Feb 19, 2012

Contributor

I cleaned up the formatting and added some missing semicolons in load-editor.js

Contributor

wieczo commented Feb 19, 2012

I cleaned up the formatting and added some missing semicolons in load-editor.js

@WPsites

This comment has been minimized.

Show comment
Hide comment
@WPsites

WPsites Feb 19, 2012

Owner

Thanks Wieczo for your contribution.

I will download your fork and take it for a test drive later today.

I have another version of this plugin in development that unfortunately I haven't yet uploaded to Github. The new version has the following improvements:

  • Does not need the built in theme/plugin editor (just incase WP decide to remove it!).
  • Has it's own file browser enabling you to edit any file in the wp-content folder and even access the backups.
  • Tabbed browsing so you can have as many files open as you need.
  • Automated backup works a little differently and doesn't show a javascript alert() instead it shows a message above the IDE

So if you really want to help with this plugin then hold out to see the new version in development. I'll get it on github today!

I'm not happy with hardly any of the current desktop editors out there and I'm sure if a few people contribute to WPide together we could create an awesome WP editor.

Owner

WPsites commented Feb 19, 2012

Thanks Wieczo for your contribution.

I will download your fork and take it for a test drive later today.

I have another version of this plugin in development that unfortunately I haven't yet uploaded to Github. The new version has the following improvements:

  • Does not need the built in theme/plugin editor (just incase WP decide to remove it!).
  • Has it's own file browser enabling you to edit any file in the wp-content folder and even access the backups.
  • Tabbed browsing so you can have as many files open as you need.
  • Automated backup works a little differently and doesn't show a javascript alert() instead it shows a message above the IDE

So if you really want to help with this plugin then hold out to see the new version in development. I'll get it on github today!

I'm not happy with hardly any of the current desktop editors out there and I'm sure if a few people contribute to WPide together we could create an awesome WP editor.

@wieczo

This comment has been minimized.

Show comment
Hide comment
@wieczo

wieczo Feb 19, 2012

Contributor

Awesome!

I am waiting for the update.

Contributor

wieczo commented Feb 19, 2012

Awesome!

I am waiting for the update.

@WPsites

This comment has been minimized.

Show comment
Hide comment
@WPsites

WPsites Feb 19, 2012

Owner

Hi Wieczo.

I've uploaded your fork to a WordPress site and it works well.

When I first created this plugin for simplicities sake I just used the basic PHP mode as that on it's own seemed like a massive improvement on the standard editor. I did plan to make it change mode depending upon the file extension but not sure when I would have got round to it.

When editing a JS or CSS file now it's awesome. Not only is the syntax highlighting miles better but it's also checking the syntax and even giving advise on best practice!

So JS and CSS are great but PHP just doesn't seem to have the same level of syntax checking, I can miss off a semicolon and it doesn't even show it up as a problem. Does something else need implementing for PHP syntax checking and advice to show?

I'm just going to upload the new dev version any time now.

I'll merge your pull request once we confirm what is going on with the PHP mode and then I'll upload it to the WordPress SVN.

Owner

WPsites commented Feb 19, 2012

Hi Wieczo.

I've uploaded your fork to a WordPress site and it works well.

When I first created this plugin for simplicities sake I just used the basic PHP mode as that on it's own seemed like a massive improvement on the standard editor. I did plan to make it change mode depending upon the file extension but not sure when I would have got round to it.

When editing a JS or CSS file now it's awesome. Not only is the syntax highlighting miles better but it's also checking the syntax and even giving advise on best practice!

So JS and CSS are great but PHP just doesn't seem to have the same level of syntax checking, I can miss off a semicolon and it doesn't even show it up as a problem. Does something else need implementing for PHP syntax checking and advice to show?

I'm just going to upload the new dev version any time now.

I'll merge your pull request once we confirm what is going on with the PHP mode and then I'll upload it to the WordPress SVN.

@wieczo

This comment has been minimized.

Show comment
Hide comment
@wieczo

wieczo Feb 19, 2012

Contributor

The problem is the ACE in itself supports workers only for CSS, CoffeeScript and JavaScript.

I think you need to create a worker to check for syntax errors and the like; I am looking at the code of ACE and can't figure out how to write one.

edit: If I understand ACE right, modes are for highlighting and workers are for syntax and style checks.

Contributor

wieczo commented Feb 19, 2012

The problem is the ACE in itself supports workers only for CSS, CoffeeScript and JavaScript.

I think you need to create a worker to check for syntax errors and the like; I am looking at the code of ACE and can't figure out how to write one.

edit: If I understand ACE right, modes are for highlighting and workers are for syntax and style checks.

@WPsites

This comment has been minimized.

Show comment
Hide comment
@WPsites

WPsites Feb 19, 2012

Owner

Hi Wieczo,

I've uploaded the v2dev branch.

It needs some work to make it ready for release on the WordPress plugin directory but it does work. The main issue I see right now is to do with the tabbed editing (multiple ace editor sessions). If you do a ctrl+z to undo then you get unexpected results, it's like all tabs undo. I think for every editor session there needs to be an associated history/undo session.

Owner

WPsites commented Feb 19, 2012

Hi Wieczo,

I've uploaded the v2dev branch.

It needs some work to make it ready for release on the WordPress plugin directory but it does work. The main issue I see right now is to do with the tabbed editing (multiple ace editor sessions). If you do a ctrl+z to undo then you get unexpected results, it's like all tabs undo. I think for every editor session there needs to be an associated history/undo session.

@wieczo

This comment has been minimized.

Show comment
Hide comment
@wieczo

wieczo Feb 20, 2012

Contributor

Will you merge my last pull request into 1.0.2?
I also have a Save shortcut which could be added.

I'll take a look later at v2dev.

Contributor

wieczo commented Feb 20, 2012

Will you merge my last pull request into 1.0.2?
I also have a Save shortcut which could be added.

I'll take a look later at v2dev.

@WPsites

This comment has been minimized.

Show comment
Hide comment
@WPsites

WPsites Feb 20, 2012

Owner

I'll merge your last pull request into 1.0.3 and push that to the WordPress plugin directory/repo.

As for the save shortcut could you just put that onto v2dev? Have a look at the dev branch anyway and let me know what you think. I think it's definitely a step forward and the sooner that can be released the better.

Owner

WPsites commented Feb 20, 2012

I'll merge your last pull request into 1.0.3 and push that to the WordPress plugin directory/repo.

As for the save shortcut could you just put that onto v2dev? Have a look at the dev branch anyway and let me know what you think. I think it's definitely a step forward and the sooner that can be released the better.

WPsites added a commit that referenced this pull request Feb 21, 2012

Merge pull request #4 from wieczo/master
Split JS Code & new modes

@WPsites WPsites merged commit b7589e4 into WPsites:master Feb 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment