Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Anime and RealSR backend #4

Closed
fefo-dev opened this issue Sep 4, 2020 · 18 comments
Closed

Issues with Anime and RealSR backend #4

fefo-dev opened this issue Sep 4, 2020 · 18 comments
Assignees
Labels

Comments

@fefo-dev
Copy link

@fefo-dev fefo-dev commented Sep 4, 2020

A continuation from this: https://old.reddit.com/r/emulation/comments/il0hdk/autocrispy_automatic_ai_upscaling/g3wyajf/

I did a clean install with the latest release (beta?) and most errors fixed themselves, every backend outside of those two worked right of the box and after changing the scaling factor. Didn't mess with other settings for now.

Anime still had the issue which we talked before - I set a file searcher to look for the output file name, and for working backends it first appears on temp folders, and after processing on the target folder as expected. Anime just quickly pops on the target folder and disappears, but even if saved there's clearly no processing done on such short time.

RealSR behaves as expected, but the output is black. There might be an issue with my setup, since I dropped everything in a folder and overwrote conflicts to test if the files are shared between backends Did a separate setup, no change. I'll file an correlated issue to it anyway.

Thanks a lot for being solicitous.

@WalkerMx WalkerMx added the bug label Sep 4, 2020
@WalkerMx WalkerMx self-assigned this Sep 4, 2020
@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

This is bizarre - I'm attempting to replicate your issue, and not seeing your results.

I want to try replicating your setup - Could I get the settings you used (Chains, Scales, etc.), and the input and output folder names, and where you have them (Docs Folder, Programs Folder, etc.)

Also, if you don't mind, could I get your hardware configuration?

On another note, the RealSR issue I've had in a couple of cases, where I ran out of VRAM.

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

I extracted the files for Anime and Real and pasted then in AC's folder, no overwriting in this case. From there I opened AC and tried the single upscaler on a throwaway .png, no change in settings. All folders are user folder and I have UAC on, so no admin prompts.

I'm running a laptop, 6° gen i5 and 960M with drivers from the last 2 weeks at least.

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

Ah! I think I got it - Are you, perhaps, adding Anime4k into the chain by itself?

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

I forgot to clarify, I didn't mess with chains at all. This is only from singular backend usage.

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

Hmm.. Add, say, three copies of Anime4k into a chain, all set at 2x scale. When you run it, do you see any temp files popping up? ("Chain_0", "Temp_0", "Single_0", etc.)

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

No, it just popped for a frame and disappeared the same. With double RealSR I saw those folders, not simultaneoulsy ofc. Black output still.

The chaining utility is... pretty nice, in a way lol

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

Alrighty, so I've posted a build here: Beta-AutoCrispy.exe

It produces a log file ("log.txt") in the same folder where the upscaled image is supposed to be. Could you give it a shot, and shoot me the log?

And, I too like the chaining feature ^^

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

First line says it all for Anime: option value is invalid: --strengthColor=0,3. Changed it to 0 and it went throught perfectly.

RealSR is less readable for me. Here's the short of it, the rest was a progress printout:
[0 GeForce GTX 960M] queueC=0[16] queueG=0[16] queueT=1[1]
[0 GeForce GTX 960M] bugsbn1=0 buglbia=0 bugcopc=0 bugihfa=0
[0 GeForce GTX 960M] fp16p=1 fp16s=1 fp16a=0 int8s=1 int8a=1
[1 Intel(R) HD Graphics 530] queueC=0[1] queueG=0[1] queueT=0[1]
[1 Intel(R) HD Graphics 530] bugsbn1=0 buglbia=0 bugcopc=0 bugihfa=0
[1 Intel(R) HD Graphics 530] fp16p=1 fp16s=1 fp16a=0 int8s=0 int8a=0
vkWaitForFences failed -4
0,00%
vkQueueSubmit failed -4

If you didn't already add a output log somewhere next.

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

Woah, wait. Perchance, is your windows install European or South American?

I totally forgot, that the default decimal separator can change. Usually, it wouldn't make a difference, but it looks like Anime4k doesn't like it. But, I can fix that, easy.

Right now, output logging is built in to the program (it was even enabled in some older builds), but I removed it from the UI because it was too cluttered. Now that I've got the tabbing control at the top, I can start adding things back in.

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

Right now, output logging is built in to the program (it was even enabled in some older builds), but I removed it from the UI because it was too cluttered. Now that I've got the tabbing control at the top, I can start adding things back in.

I can see a settings tab eventually, seems good. A --output flag could help for now.

Yes, I'm using pt-br (install might been en-us), so decimals are separated by commas.

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

Give this a shot Beta-AutoCrispy.exe

I think, this also has "folder detecting", it can see the backends even if they're in sub-folders. I haven't done ESRGAN yet, though.

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

Yes it does for all but ESRGAN. Digs only 1 sublevel which I like, too deep and you might end with noise. Also I had Anime on both the same folder and a subfolder, it showed both entries separated on the list. Great for multiple settings.

Set anime back to 0.3 and it worked, good job. If you touched RealSR it's still broken here.

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

I'm still looking at RealSR. What happens when you run it from the command line?

My work laptop has Integrated and Dedicated graphics, and I have to disable the Integrated Graphics to get RealSR to work properly.

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

First run was with a .png, which seems unsuported from a glance in the docs. Second was with a .jpg without messing with graphics settings. Third was after setting it to use dedicated graphics. Output was nothing, black and black. No setting for fully disabling integrated graphics, so I gotta trust Optimus.

Second log matches what AC produced using a .png

B:+\AutoCrispy\realsr-ncnn-vulkan-20200818-windows>realsr-ncnn-vulkan.exe -i input.jpg -o output.png -s 4
[0 GeForce GTX 960M] queueC=0[16] queueG=0[16] queueT=1[1]
[0 GeForce GTX 960M] bugsbn1=0 buglbia=0 bugcopc=0 bugihfa=0
[0 GeForce GTX 960M] fp16p=1 fp16s=1 fp16a=0 int8s=1 int8a=1
[1 Intel(R) HD Graphics 530] queueC=0[1] queueG=0[1] queueT=0[1]
[1 Intel(R) HD Graphics 530] bugsbn1=0 buglbia=0 bugcopc=0 bugihfa=0
[1 Intel(R) HD Graphics 530] fp16p=1 fp16s=1 fp16a=0 int8s=0 int8a=0
decode image input.jpg failed

B:+\AutoCrispy\realsr-ncnn-vulkan-20200818-windows>realsr-ncnn-vulkan.exe -i input.jpg -o output.png -s 4
[0 GeForce GTX 960M] queueC=0[16] queueG=0[16] queueT=1[1]
[0 GeForce GTX 960M] bugsbn1=0 buglbia=0 bugcopc=0 bugihfa=0
[0 GeForce GTX 960M] fp16p=1 fp16s=1 fp16a=0 int8s=1 int8a=1
[1 Intel(R) HD Graphics 530] queueC=0[1] queueG=0[1] queueT=0[1]
[1 Intel(R) HD Graphics 530] bugsbn1=0 buglbia=0 bugcopc=0 bugihfa=0
[1 Intel(R) HD Graphics 530] fp16p=1 fp16s=1 fp16a=0 int8s=0 int8a=0
vkWaitForFences failed -4
0,00%
vkQueueSubmit failed -4
16,67%
33,33%
50,00%
66,67%
83,33%

B:+\AutoCrispy\realsr-ncnn-vulkan-20200818-windows>realsr-ncnn-vulkan.exe -i input.jpg -o output.png -s 4
[0 GeForce GTX 960M] queueC=0[16] queueG=0[16] queueT=1[1]
[0 GeForce GTX 960M] bugsbn1=0 buglbia=0 bugcopc=0 bugihfa=0
[0 GeForce GTX 960M] fp16p=1 fp16s=1 fp16a=0 int8s=1 int8a=1
vkWaitForFences failed -4
0,00%
vkQueueSubmit failed -4
16,67%
33,33%
50,00%
66,67%
83,33%

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 4, 2020

I think, in Device Manager (devmgmt.msc) you can disable the integrated graphics (it's under "Display Adapters").

RealSR does support PNG, JPG, and WEBP. This looks like it might be some sort of issue with RealSR, if it's giving the same error when you run it directly from the command line.

I'll keep looking into this.

@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 4, 2020

Yes, there's clearly more to it here. I should made an issue for each, I wanted to keep the context but they're very separate in nature.

Feel free to close it unless you want to add more stuff, it doesn't seem to be anything in your end.

@WalkerMx
Copy link
Owner

@WalkerMx WalkerMx commented Sep 5, 2020

Noted. I'll go ahead and close this one, and finish implementing that feature request.

Thank you very much for your help. If you're not opposed, I'd like to add you to the "Thanks" section on the official page?

@WalkerMx WalkerMx closed this Sep 5, 2020
@fefo-dev
Copy link
Author

@fefo-dev fefo-dev commented Sep 5, 2020

If you so desire, sure. This is a cool tool, you put a lot of work in such a short time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.