Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCIP-6: Silent Payloads #6

Open
pedrouid opened this issue Jun 7, 2019 · 0 comments

Comments

1 participant
@pedrouid
Copy link
Member

commented Jun 7, 2019

Currently we have a Push server infrastructure that subscribes to topics received by a Bridge server as a third-party that provides a Webhook that will trigger notifications on the user's Wallet.

There is however certain payloads, more concretely Ethereum read JSON-RPC requests and WalletConnect session related JSON-RPC requests which shouldn't require to notify the user of the incoming requests.

We should only trigger these notifications whenever the user is required to sign/authenticate these requests from the Wallet side. Hence I would like to propose an additional parameter to the SocketMessage payloads that are to be received by the Bridge server.

This additional parameter would be named silent and it would be a boolean value with default to false in order to maintain backwards compatibility with previous iterations. For future versions, all payloads would have a value of true except for signing requests which in the case of Ethereum would be eth_sendTransaction, eth_signTransaction, eth_sign, eth_signTypedData and personal_sign.

@pedrouid pedrouid moved this from To do to In progress in WalletConnect v2.0 Protocol Jun 24, 2019

@pedrouid pedrouid removed this from In progress in WalletConnect v2.0 Protocol Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.