Improve Docker setup + Certbot + Redis DB #30
Conversation
Installable dependencies modifications according to certbot website now runs on 5001 port copying build directory to Docker image runs webapp in 5 seconds after redis
Add the following to the
|
Please, review @pedrouid |
Hey @agutsal, I tested this in a Digital Ocean droplet but certbot was forcing me to choose a domain which I didn't pick. I used @janus fork of your branch so that I could test both changes at the same time since most of his changes are on the app side. I believe your changes are the ones related to the ssl certificates. Basically I saw the messages display above. It asks which names to activate but only allows for I have forked @janus fork to add the However in order to replicate my bug, here are the steps.
I was able to do the whole process until I hit ssl certificate generation problem on |
Hey @agutsal, I just compared your file and @pedrouid on nginx configuration, I found the followings:
|
add missing files
@pedrouid tested locally - still attempts to use I'm new to certbot but found that: Now we should find where that |
Let's use Discord, go to https://discord.walletconnect.org |
it redirects to |
My Discord is also not loading for some reason |
Let's use the WalletConnect Gitter which is unused |
Hi team, I think I found the problem referenced on https://community.letsencrypt.org/t/certbot-keeps-suggesting-ngrok-domain/96456 The default nginx configuration has an ngrok address at the following line. https://github.com/WalletConnect/node-walletconnect-bridge/pull/30/files#diff-5c29fc0b85522159c4dce0482195bdd8R10 |
Wow I can't believe we missed that, thanks a lot for your help! 🙏 |
Anytime, best of luck out there! That combined with the changes to the the Makefile at https://github.com/WalletConnect/node-walletconnect-bridge/pull/30/files#diff-b67911656ef5d18c4ae36cb6741b7965R23 I think are what puts the ngrok domain into the container. |
I already fixed it |
OK. So you're testing now? |
Yes, the Docker setup works fine, but the RedisDB implementation is not working yet so I can't merge this yet |
I'm fixing them now, but @janus please pay more attention next time because there were typos plus all redis calls are asynchronous but you didn't adapt them in the rest of the app. |
@pedrouid thx man, and sorry for |
Hey @agutsal, can you merge aahutsal#2? |
done |
Sorry for the inconvenience ... I initially asked for test data so that I could test it. It was untested ... |
Fix #25