New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longpolling not working #25

Closed
ligi opened this Issue Jul 24, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@ligi
Copy link
Member

ligi commented Jul 24, 2018

regarding to this documentation there should be long-polling when getting accounts. But the bridge is instantly answering with a 204 which leads to a very short polling and high traffic - e.g. see this log: https://gist.github.com/ligi/09fa5a672e7810ef83bc0b9b12cfdd2b which i got running https://github.com/balance-io/ethereum-store - there https://walletconnect.balance.io/session/ is GETed in very high frequency

@pedrouid

This comment has been minimized.

Copy link
Member

pedrouid commented Jul 25, 2018

I see what you mean, totally missed the point when we were discussing it before. That's correct right now WalletConnect does a short-polling answering with a 204. Do you think that this should be a long-polling instead?

@pedrouid pedrouid assigned pedrouid and unassigned pedrouid Jul 25, 2018

@ligi

This comment has been minimized.

Copy link
Member Author

ligi commented Jul 25, 2018

Do you think that this should be a long-polling instead?

The documentation states there is long polling here - and I think it makes sense as getting out the phone, potentially unlocking, opening the app and scanning the QR code might take some time. It would reduce the load on the bridge server and decrease traffic.

@pedrouid

This comment has been minimized.

Copy link
Member

pedrouid commented Jul 29, 2018

Sounds good, let's make this change then

@pedrouid

This comment has been minimized.

@pedrouid pedrouid closed this Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment