feat: upgrade otel #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
requested review from
geekbrother,
heilhead,
nopestack and
xDarksome
heilhead
approved these changes
Apr 16, 2024
Collaborator
heilhead
left a comment
heilhead
left a comment
There was a problem hiding this comment.
So good to see these useless contexts gone!
geekbrother
approved these changes
Apr 16, 2024
Collaborator
geekbrother
left a comment
geekbrother
left a comment
There was a problem hiding this comment.
RIP &otel::Context::new() 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade opentelemetry version to make histograms work properly by using exponential histograms.
Slack conversation
Breaking changes
ctxparam removed from metric recording functionsHow Has This Been Tested?
The histogram feature not tested, will test in Notify Server in prod.
Usage in: reown-com/notify-server#479
Due Diligence