Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Provider #178

Merged
merged 8 commits into from Aug 20, 2019

Conversation

@pedrouid
Copy link
Member

commented Aug 10, 2019

No description provided.

*/
channel.deposit({
amount: "0x3abc", // represented as bignumber
assetId: AddressZero // Use the AddressZero constant from ethers.js to represent ETH, or enter the token address

This comment has been minimized.

Copy link
@LayneHaber

LayneHaber Aug 10, 2019

You can enter this as just amount as a string, or leave the assetId as undefined if you are transferring eth.

the string --> bignumber and assetId --> AddressZero conversions will happen automatically

* Withdrawing
*/
await channel.withdraw({
recipient: // defaults to signer xpub but can be changed to withdraw to any recipient

This comment has been minimized.

Copy link
@LayneHaber

LayneHaber Aug 10, 2019

defaults to signer accounts[0], recipient should be an ETH address not an xpub

@pedrouid pedrouid marked this pull request as ready for review Aug 20, 2019

@pedrouid pedrouid merged commit 3ff81fe into master Aug 20, 2019

11 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (pedrouid) No manifest changes detected
security/snyk - packages/browser/package.json (pedrouid) No new issues
Details
security/snyk - packages/core/package.json (pedrouid) No new issues
Details
security/snyk - packages/qrcode-modal/package.json (pedrouid) No new issues
Details
security/snyk - packages/react-native/package.json (pedrouid) No new issues
Details
security/snyk - packages/types/package.json (pedrouid) No new issues
Details
security/snyk - packages/utils/package.json (pedrouid) No new issues
Details
security/snyk - packages/web3-provider/package.json (pedrouid) No new issues
Details
security/snyk - packages/web3-subprovider/package.json (pedrouid) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.