chore: dismiss modal #370
Merged
chore: dismiss modal #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thanks @devceline I can now dismiss it. 
|
devceline
commented
Jan 11, 2024
src/utils/notifications.ts
Outdated
| } | ||
|
|
||
| export const checkIfNotificationModalClosed = () => { | ||
| const storageValue = localStorage.getItem(localStorageKeys.notificationModalClosed) |
Contributor
Author
There was a problem hiding this comment.
this needs to be guarded
devceline
commented
Jan 11, 2024
Contributor
Author
devceline
left a comment
devceline
left a comment
There was a problem hiding this comment.
LGTM, @enesozturk please fix the comment and merge the PR
enesozturk
force-pushed
the
fix/dismiss-notifs-desktop
branch
from
49e574e to
c7d0997
Compare
enesozturk
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localStorageto prevent asking for notif permissions