Skip to content

fix: ensure every catch logs the underlying error to console #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix: ensure every catch logs the underlying error to console #382

merged 2 commits into from
Jan 11, 2024

Conversation

@bkrem
Copy link
Member

@bkrem bkrem commented Jan 11, 2024 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@bkrem bkrem requested review from devceline and enesozturk January 11, 2024 17:35
@vercel
Copy link

vercel bot commented Jan 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 5:52pm

devceline
devceline approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkrem bkrem merged commit 3d2548c into main Jan 11, 2024
@bkrem bkrem deleted the fix/ensure-every-error-toast-logs-error branch January 11, 2024 19:18
@bkrem bkrem changed the title fix: ensure every error toast logs the underlying error to console fix: ensure every catch logs the underlying error to console Jan 11, 2024
@bkrem bkrem mentioned this pull request Jan 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enesozturk enesozturk Awaiting requested review from enesozturk

1 more reviewer

@devceline devceline devceline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkrem @devceline