Display a unique error message for invalid coins being spent.

[Kruwed]

Sometimes, a users wallet gets out of sync. When they try to create an invalid transaction that uses already spent coins, or coins that do not exist because they were replaced, they receive a message saying "There are not enough funds to cover the transaction fee": #11902 This error message is inaccurate (especially since this message will appear before the user can select the fee).

Related, but out of scope - Rescanning fixes the issue, so it would be useful to automatically trigger a rescan in the background when an attempt to spend invalid coins fails - #11621

[Kruwed]

I just encountered this error, so it appears a dedicated message exists:

2024-01-06 18:11:58.416 [1] INFO TransactionBroadcaster.BroadcastTransactionToNetworkNodeAsync (47) Trying to broadcast transaction with random node (::ffff:132.145.213.181):2a8dbf310c5b4f04ea178ed9e34a186442a4ed2f3c4275a585cbca7cae2f4cc9.
2024-01-06 18:12:02.735 [19] INFO P2pBehavior.ProcessGetDataAsync (111) Successfully served transaction to node ([::ffff:132.145.213.181]:18333): 2a8dbf310c5b4f04ea178ed9e34a186442a4ed2f3c4275a585cbca7cae2f4cc9.
2024-01-06 18:12:02.735 [31] INFO P2pBehavior.ProcessGetDataAsync (111) Successfully served transaction to node ([::ffff:132.145.213.181]:18333): 2a8dbf310c5b4f04ea178ed9e34a186442a4ed2f3c4275a585cbca7cae2f4cc9.
2024-01-06 18:12:03.473 [31] INFO TransactionBroadcaster.BroadcastTransactionToNetworkNodeAsync (71) Disconnected node: ::ffff:132.145.213.181. Successfully broadcasted transaction: 2a8dbf310c5b4f04ea178ed9e34a186442a4ed2f3c4275a585cbca7cae2f4cc9.
2024-01-06 18:12:25.743 [14] INFO TransactionBroadcaster.SendTransactionAsync (178) Random node could not broadcast transaction. Reason: Did not serve the transaction..
2024-01-06 18:12:25.751 [14] INFO TransactionBroadcaster.BroadcastTransactionToBackendAsync (94) Broadcasting with backend...
2024-01-06 18:12:27.736 [1] ERROR TransactionPreviewViewModel.OnConfirmAsync (401) System.Net.Http.HttpRequestException: Bad Request
bad-txns-inputs-missingorspent:::
at WalletWasabi.Tor.Http.Extensions.HttpResponseMessageExtensions.ThrowRequestExceptionFromContentAsync(HttpResponseMessage me, CancellationToken cancellationToken) in WalletWasabi\Tor\Http\Extensions\HttpResponseMessageExtensions.cs:line 122
at WalletWasabi.WebClients.Wasabi.WasabiClient.BroadcastAsync(String hex) in WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 147
at WalletWasabi.WebClients.Wasabi.WasabiClient.BroadcastAsync(Transaction transaction) in WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 153
at WalletWasabi.WebClients.Wasabi.WasabiClient.BroadcastAsync(SmartTransaction transaction) in WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 158
at WalletWasabi.Blockchain.TransactionBroadcasting.TransactionBroadcaster.BroadcastTransactionToBackendAsync(SmartTransaction transaction) in WalletWasabi\Blockchain\TransactionBroadcasting\TransactionBroadcaster.cs:line 101
at WalletWasabi.Blockchain.TransactionBroadcasting.TransactionBroadcaster.SendTransactionAsync(SmartTransaction transaction) in WalletWasabi\Blockchain\TransactionBroadcasting\TransactionBroadcaster.cs:line 197
at WalletWasabi.Fluent.ViewModels.Wallets.Send.TransactionPreviewViewModel.SendTransactionAsync(SmartTransaction transaction) in WalletWasabi.Fluent\ViewModels\Wallets\Send\TransactionPreviewViewModel.cs:line 429

[Kruwed]

Shouldn't run into this anymore.