This repository has been archived by the owner. It is now read-only.

Express: Link to source on github. #149

Merged
merged 3 commits into from Mar 5, 2012

Conversation

Projects
None yet
2 participants
@nrn
Collaborator

nrn commented Mar 2, 2012

Link to the latest commit on github at the bottom of the page on the express server. #148

WardCunningham added a commit that referenced this pull request Mar 5, 2012

Merge pull request #149 from nrn/master
Express: Link to source on github.

@WardCunningham WardCunningham merged commit c26c67d into WardCunningham:master Mar 5, 2012

@WardCunningham

This comment has been minimized.

Show comment
Hide comment
@WardCunningham

WardCunningham Mar 5, 2012

Owner

How about we embed this git information in an html comment, not in a visible link?

It might take some experimenting to figure out what kind of links are and aren't clickable in show-source. I was waiting to pull this until I had some time to match it in sinatra. But I see there is another commit I don't want to hold up.

Owner

WardCunningham commented Mar 5, 2012

How about we embed this git information in an html comment, not in a visible link?

It might take some experimenting to figure out what kind of links are and aren't clickable in show-source. I was waiting to pull this until I had some time to match it in sinatra. But I see there is another commit I don't want to hold up.

@nrn

This comment has been minimized.

Show comment
Hide comment
@nrn

nrn Mar 5, 2012

Collaborator

I probably should have done that git stuff in a branch, I'll take a look for an easy way for the developers to get to a link but not users later today.

Collaborator

nrn commented Mar 5, 2012

I probably should have done that git stuff in a branch, I'll take a look for an easy way for the developers to get to a link but not users later today.

@nrn

This comment has been minimized.

Show comment
Hide comment
@nrn

nrn Mar 6, 2012

Collaborator

I took a look at this and didn't see any consistently good way to do it. What is a clickable link depends both on which browser you're using and how you are looking at the source You can even click on a console.log('url as a string') in chrome which is pretty slick, but no such luck in firebug.

Collaborator

nrn commented Mar 6, 2012

I took a look at this and didn't see any consistently good way to do it. What is a clickable link depends both on which browser you're using and how you are looking at the source You can even click on a console.log('url as a string') in chrome which is pretty slick, but no such luck in firebug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.