Fetching and saving pages combined #201

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Collaborator

nrn commented Apr 19, 2012

I moved fetch to pageHandler, and added the code for saving pages from legacy.

Owner

WardCunningham commented Apr 20, 2012

Sweet.

But I thought that git could handle file renames better than this. Did you use git mv fetch PageHandler?

Collaborator

nrn commented Apr 20, 2012

It got a bit tangled with me stashing, pulling, and then reapplying changes, so maybe I didn't. It is supposed to auto detect those things though :/

Owner

WardCunningham commented Apr 22, 2012

I tried to merge this code today but ran into several problems.

  • won't create new page when referenced in url
  • won't complete creation of new paragraph when text dropped on factory
  • won't create new page when axis label of radar chart clicked

I thought to look in some of these places after doing a global search for putAction, an api call that this commit renames.

Collaborator

nrn commented Apr 23, 2012

Whoops, sorry Ward, I'll go through this stuff tomorrow.

Collaborator

nrn commented Apr 23, 2012

Hmm, I went off in a weird direction after this stuff that didn't pan out, and it looks like when I trashed it I threw out a bunch of stuff that I thought was in this commit... I'll get this straightened up and resubmit.

@nrn nrn closed this Apr 23, 2012

Owner

WardCunningham commented Apr 23, 2012

Now I'm thinking the page creation logic may have gotten messed up with an earlier refactoring.

Owner

WardCunningham commented Apr 24, 2012

Ran a git-bisect and found that the creation logic problems are from this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment