Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

improvements on new journal ui #227

Merged
merged 3 commits into from May 13, 2012

Conversation

Projects
None yet
2 participants
Contributor

hallahan commented May 12, 2012

The buttons were not working right. When the journal got filled up post page load, the controls did not stick to the bottom. I also lined everything up the best I could for a normal size view. It is behaving tolerably now in IE, Firefox, Chrome.

The way I have it now, if there is one action that pushes out the Fork control, every control (I made a control group) goes down to the next row.

It has occurred to me that this functionality of coffee-script takes away the need of a templating library. Maybe we should consider this sort of styling for view related code. It may be a good idea to have a file just for view construction in a format similar to this.

I like fat padding for white space, but I also like having 3 pages fit on my screen. I'm curious to see what other people do with their themes.

Owner

WardCunningham commented May 12, 2012

I'd like to mention to others here that Nick (@hallahan) and I have put some effort into integrating the design work he showed in our last video chat. My focus has been on keeping the platform simple and open while delivering substantial new capability to users at every level, including those who will make their own sites beautiful.

As an open source project we must also be careful to not go too far without open discussion of this work in public. This morning I found myself emailing Nick screen shots I want to share now:

The gist is that I'd like all the css that gives federated wiki functionality to be available to help-text authors when they explain that functionality. Normally authors use captured images. But how can we share help text with captures through the federation when local customization has been encouraged? Answer: replace captures with html using the same (carefully factored) css.

@WardCunningham WardCunningham merged commit 2d1dbb6 into WardCunningham:master May 13, 2012

Owner

WardCunningham commented May 13, 2012

f804dbe seems to resolve the placement problem I mentioned in my previous comment. Cool.

Contributor

hallahan commented May 13, 2012

Great, yeah that makes sense. The button group is what right orients now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment