Map plugin and page #276

Merged
merged 3 commits into from Aug 22, 2012

Projects

None yet

2 participants

@asolove
Contributor
asolove commented Aug 22, 2012

This pull request adds a basic map plugin and page. I think it is a good common basis for adding other geographic features, like auto-detection of geographic data in data plugins or from locations mentioned in the edit history.

I am using mapquest, because they have a free, public API for loading open-source OpenStreetMap map tiles. They also have a convenient javascript api for adding annotations like points, regions, icons, etc. on top of the maps, comparable to Leaflet.

@WardCunningham

Awesome. I can't wait to see it. Next time include a screenshot for the chronically impatient.

@WardCunningham WardCunningham merged commit 50f29b6 into WardCunningham:master Aug 22, 2012
@WardCunningham
Owner

I'm liking this plugin a lot, even as it struggles a little to get along with everything else going on in our interface.

I wonder if we could turn on and off the panning and zooming by entering into an edit mode on double-click. This would let drag mean move-plugin unless you were editing the map, then drag would mean pan.

The mapquest javascript seems to only want to put controls up on one map at a time anyway. Let's make it clear which one that should be by clicking into edit mode.

Another advantage of the mode would be that journal actions would only need to be recorded on exit.

Thanks for considering all this.

@asolove
Contributor
asolove commented Aug 22, 2012

Thanks for adding the extra documentation! I wasn't sure how to integrate this into the UI. Your suggestion reinforces the idea we had earlier of introducing an explicit edit mode. This is especially necessary on mobile, where people will be tapping and dragging without wanting to actually edit content. I will try adding this in and see how it feels.

@WardCunningham
Owner

Now is a good time for others to reread the conversation in Issue #261 and add pragmatic advice here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment