Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Punt Records Browser/OS, Factory generates Plugins from Menu in Ub12.04 #349

Merged
merged 8 commits into from Feb 16, 2013

Conversation

Projects
None yet
3 participants
Contributor

rynomad commented Jan 29, 2013

Sorry the commit tree in this pull request is messy, still getting the hang of this.

cd51799 - cleans /n newlines out of plugin calls from factory, which was bugging up my system

47caa25 - added attribution and url to source of the BrowserDetect script

579de83 - Punt now records users browser and version, as well as OS. Generates a paragraph that reads:

"Trouble: We detected the drop but cannot yet make sense of the information provided by your browser and operating system. Try something different. If you know that your drop should have worked and you want to file a bug report you can do so on [https://github.com/WardCunningham/Smallest-Federated-Wiki/issues github]. Please Provide the json data for this paragraph, (click JSON on the bottom of this page)"

The rest of the commits here are a result of me trying to update my forked copy of SFW from the master branch, which then automatically added them to the pull request... like I said, still gettin the hang of it. Hope it's not a pain to separate out.

Contributor

paul90 commented on cd51799 Feb 9, 2013

This change is needed for the factory to work with Windows browsers - at least Firefox, Chrome seems to cope, and IE falls over before displaying the text box might be related!.

This is related to a know fault in coffee script - see jashkenas/coffee-script#240. This fault may well cause problems elsewhere...

Not sure if the coffee script will ever be fixed, it has been unfixed for 3 years now. On the assumption the underlying coffee script fault will not be fixed, there are two possible solutions:

  1. Remove all the line breaks in text that is printed - searching for \n in the generated javascript - there are quite a lot of them many probably don't cause any problems, but...
  2. Change this project to use just linefeed line endings, together with the necessary git and editor changes to ensure that \r\n line endings don't get reintroduced unwittingly.

WardCunningham added a commit that referenced this pull request Feb 16, 2013

Merge pull request #349 from rynomad/master
Punt Records Browser/OS, Factory generates Plugins from Menu in Ub12.04

@WardCunningham WardCunningham merged commit 9e41946 into WardCunningham:master Feb 16, 2013

Owner

WardCunningham commented Feb 17, 2013

I'm sorry it too so long to get to this. After trying it out it occurred to me that we should leave the factory as a factory and use the factory's prompt mechanism to report advice.

Contributor

rynomad commented Feb 20, 2013

No problem, I've been working on a number of other projects myself. Thanks for pulling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment