This repository has been archived by the owner. It is now read-only.

Updating Mocha, plus resolving IE 9 & 10 issues. #368

Merged
merged 19 commits into from Mar 12, 2013

Conversation

Projects
None yet
2 participants
@paul90
Contributor

paul90 commented Mar 12, 2013

This incorporates, and replaces #366.

This bunch of commits include

  • updates to both the main and test libraries - resolving some Internet Explorer issues.
  • adding Modernizr, plus a test for cors support, loading a polyfill if needed (needed for IE 9).
  • resolving a couple of css issues with IE (height of newer/older flags, and removing borders around images in links).
  • batch files for building client and testclient
  • change report tests to use JSON.stringify rather than date.tostring to resolve issue with IE using a different date format.
@paul90

This comment has been minimized.

Show comment
Hide comment
@paul90

paul90 Mar 12, 2013

Contributor

The only errors I am currently seeing in the Mocha tests are with Internet Explorer 9 & 10

  • "should render a plugin" - string does not match as the attributes in the link are in a different order (title coming first rather than last).
    Error: expected <p>blah <a title="view" class="internal" href="/link.html" data-page-name="link">Link</a> asdf</p> to equal <p>blah <a class="internal" href="/link.html" data-page-name="link" title="view">Link</a> asdf</p> it would be possible to change this test to look at the DOM object, but...
  • report plugin - advancing
    "handles weeks",
    "handles weeks with offsets (noon > now)",
    "handles years with offsets (march < now)", and
    "handles election day (election > now)"
    with the original test these all fail as IE uses a different toString format day of the week month day hour: minute:second time zone year ! Changed the test to use JSON.stringify to resolve.
Contributor

paul90 commented Mar 12, 2013

The only errors I am currently seeing in the Mocha tests are with Internet Explorer 9 & 10

  • "should render a plugin" - string does not match as the attributes in the link are in a different order (title coming first rather than last).
    Error: expected <p>blah <a title="view" class="internal" href="/link.html" data-page-name="link">Link</a> asdf</p> to equal <p>blah <a class="internal" href="/link.html" data-page-name="link" title="view">Link</a> asdf</p> it would be possible to change this test to look at the DOM object, but...
  • report plugin - advancing
    "handles weeks",
    "handles weeks with offsets (noon > now)",
    "handles years with offsets (march < now)", and
    "handles election day (election > now)"
    with the original test these all fail as IE uses a different toString format day of the week month day hour: minute:second time zone year ! Changed the test to use JSON.stringify to resolve.

@WardCunningham WardCunningham merged commit 2a1ad22 into WardCunningham:master Mar 12, 2013

@WardCunningham

This comment has been minimized.

Show comment
Hide comment
@WardCunningham

WardCunningham Mar 12, 2013

Owner

This is a big pull. Thanks.

I took stringify out of the tests because that doesn't seem consistent either. Let's try comparing Date objects, not the print representation of Date objects.

There are parts of this pull that I don't understand. That makes me nervous. It would be great to get a verbal walk-through sometime. Email me if you are willing to spend a half-hour with me.

Owner

WardCunningham commented Mar 12, 2013

This is a big pull. Thanks.

I took stringify out of the tests because that doesn't seem consistent either. Let's try comparing Date objects, not the print representation of Date objects.

There are parts of this pull that I don't understand. That makes me nervous. It would be great to get a verbal walk-through sometime. Email me if you are willing to spend a half-hour with me.

@paul90 paul90 deleted the paul90:win-ie branch Mar 13, 2013

This was referenced Mar 15, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.