Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

More tests, refactoring #56

Merged
merged 10 commits into from Nov 7, 2011

Conversation

Projects
None yet
2 participants
Contributor

BryanDonovan commented Nov 7, 2011

Hi Ward,

This fork adds test coverage for the Page class and moves the mkfavicon method from the server.rb file to its own Favicon class with a minimal unit test.

-Bryan

Contributor

BryanDonovan commented Nov 7, 2011

p.s., I've created another branch where I've added a subdirectory named 'sfw' under server/, and namespaced all the classes with 'Sfw::'. See https://github.com/BryanDonovan/Smallest-Federated-Wiki/tree/sfw-namespace/server

Let me know if you think I should proceed with that direction. It's more typing, but I think it clarifies what is home-grown and what is a 3rd party library, and might help prevent future namespace collisions.

Are the parens required? Or just style?

Help me understand what is going on here. Thanks.

Owner

BryanDonovan replied Nov 7, 2011

The TEST_DATA_DIR and APP_DATA_DIR were being set in this test, but the next test that ran needed them to not be set. Easiest solution is to wrap them in a module to keep them out of the global namespace.

oops. I thought I removed those.

@WardCunningham WardCunningham merged commit aab5e78 into WardCunningham:master Nov 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment