Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Only the host sees who quit #1020

Closed
wzdev-ci opened this issue Oct 22, 2009 · 30 comments
Closed

Only the host sees who quit #1020

wzdev-ci opened this issue Oct 22, 2009 · 30 comments

Comments

@wzdev-ci
Copy link
Contributor

keyword_quit_quitting resolution_fixed type_bug | by truckspin


Since a few versions, maybe since 2.2.2 or 2.2.3, it happens very often that somebody quits (only for certain types of crashes or also for regular quitting?) and only the host gets notified about it. The other players still see that player with ping ??? in the game, and all his units and buildings remain in the game. That is a major annoyance, because even teammates can't take his oil, so the game is over when that happens.

Sometimes this happens, and sometimes they do see who quit. I can't say more about the reproduction than to play a few online games; it happens often.


Issue migrated from trac:1020 at 2022-04-15 19:53:40 -0700

@wzdev-ci
Copy link
Contributor Author

-Kosh- commented


There is a icon that appears when it detects someone dropped.
The ??? means it can not calculate the ping time most likely.

@wzdev-ci
Copy link
Contributor Author

Buginator changed status from new to pending

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Oct 30, 2009

Buginator commented


Replying to Warzone2100/old-trac-import#1020 (comment:1):

There is a icon that appears when it detects someone dropped.
The ??? means it can not calculate the ping time most likely.

You should see the icon, as he said. Everyone should...

If this is not the case, then please post back.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 1, 2009

truckspin commented


This is not entirely wrong, but not relevant either.

I don't care about icons. I don't care if they "know" who quit; that could be simply worked around by the host telling everyone who quit.

The real problem is:

all his units and buildings remain in the game. That is a major annoyance, because even teammates can't take his oil, so the game is over when that happens.

This has nothing to do with any icons. His teammates just can't take the oil, and the buildings and units remain in the game, even when the user turns off his computer and burns it.

It happened a few releases ago and still is that way.

(And they don't get the icon either in that case, but that's not the problem. Also we all know what a ??? ping means.)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 1, 2009

truckspin changed status from pending to new

@wzdev-ci
Copy link
Contributor Author

anonymous commented


Also note that when this happens, the host can get a victory screen while his OWN TEAMMATES don't.

Please don't forget this easily reproducible bug; it is a major annoyance!

@wzdev-ci
Copy link
Contributor Author

Zarel commented


It's hardly "easily reproducible" - I've never seen it happen, unfortunately.

@wzdev-ci
Copy link
Contributor Author

truckspin commented


Can't be! It happens for about 50 % of all clients who quit/crash! When it started to happen last year in some 2.2.x I didn't even bother to report it, because it was so obvious that I was sure it would be fixed immediately.

@wzdev-ci
Copy link
Contributor Author

Zarel commented


Sync bugs are near impossible to fix immediately. Only the host seeing when someone quits is just that - a sync bug.

@wzdev-ci
Copy link
Contributor Author

Zarel changed priority from critical to blocker

@wzdev-ci
Copy link
Contributor Author

Zarel commented


I agree with Per. Blocker priority.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 5, 2010

Buginator changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 5, 2010

Buginator set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 5, 2010

Buginator commented


(In [9644]) Change / add a few log WARNINGS to INFO instead, to track down why the game thinks that people have left when they haven't, and also fix the bug of not destroying the player who dropped / left feature(s).

fixes #1020

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 6, 2010

Buginator commented


(In [9704]) frontport [9644]

"Change / add a few log WARNINGS to INFO instead, to track down why the game thinks that people have left when they haven't, and also fix the bug of not destroying the player who dropped / left feature(s).

fixes #1020"

@wzdev-ci
Copy link
Contributor Author

kai changed resolution from fixed to ``

@wzdev-ci
Copy link
Contributor Author

kai commented


It's back :-(
ver 2.3.0

This time the host's units CAN get hurt by ghost defences.

@wzdev-ci
Copy link
Contributor Author

kai changed status from closed to reopened

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 30, 2010

Crymson commented


Replying to Warzone2100/old-trac-import#1020 (comment:11):

It's back :-(
ver 2.3.0

This time the host's units CAN get hurt by ghost defences.

What does that mean? The player never drops?

I haven't run into this issue with 2.3.0

@wzdev-ci
Copy link
Contributor Author

kai commented


Right, even after more than an hour, the clients still see the frozen client, and the host doesn't see it but still gets hurt by defences when he comes close.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 3, 2010

hao commented


I've seen this several times too, in 2.3.1 also. I usually see ping 1000 instead of ??? in that case. I still see the defenses and units of the player who has left, and it can hurt me, and even if the host comes near these units, his units can die because my computer reports them dead.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 5, 2010

Zarel commented


More information in #1716, #1715

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 9, 2010

Buginator changed status from reopened to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 9, 2010

Buginator changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 9, 2010

Buginator commented


(In [11109]) When player disconnects / drops, handle the message, instead of the clients ignoring it.

Fixes #1020

@wzdev-ci wzdev-ci closed this as completed Jul 9, 2010
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 9, 2010

Buginator commented


(In [11111]) Backport [11109]

When player disconnects / drops, handle the message, instead of the clients ignoring it.

Fixes #1020

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented


(In Warzone2100/warzone2100@8e02c3d) When player disconnects / drops, handle the message, instead of the clients ignoring it.

Fixes #1020

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11109 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Buginator commented


(In [11123]) Backport [11109]

When player disconnects / drops, handle the message, instead of the clients ignoring it.

Fixes #1020

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Oct 9, 2010

Git SVN Gateway <gateway@...> commented


In Warzone2100/warzone2100@8e02c3d:

#CommitTicketReference repository="" revision="8e02c3d3eacc5437fb1218d4741e4ca258833da7"
When player disconnects / drops, handle the message, instead of the clients ignoring it.

Fixes #1020


git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11109 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented


In Warzone2100/warzone2100@8e02c3d:

#CommitTicketReference repository="" revision="8e02c3d3eacc5437fb1218d4741e4ca258833da7"
When player disconnects / drops, handle the message, instead of the clients ignoring it.

Fixes #1020


git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11109 4a71c877-e1ca-e34f-864e-861f7616d084

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant