Crash when saving with proximity display list out of sync with proximity message list

[wzdev-ci]

keyword_messages_blips resolution_fixed type_bug | by Ai_Tak

---

This happened while I was making a saved game to report the missing oil indicators, it crashed without making the *.es file and half the files in the sub-directory. I saved before seeing any messed up oil (right after skirmish setup) and had no trouble. Same stderr.txt as in #1430.

stderr.txt:

error |11:26:59: [writeMessageFile] Save message; proximity display not found for message
error |11:26:59: [writeMessageFile] Assert in Warzone: ../../../src/game.c:10655 (psProx != ((void *)0)), last script event: 'N/A'

warzone2100.RPT:
http://pastebin.com/f2c5d3969

---

Issue migrated from trac:1443 at 2022-04-15 20:55:55 -0700

[wzdev-ci]

Per changed status from new to assigned

[wzdev-ci]

Per changed component from other to Engine: other

[wzdev-ci]

Per changed title from Assert while saving (psProx != ((void *)0)) to Crash when saving with proximity display list out of sync with proximity message list

[wzdev-ci]

Per set owner to Per

[wzdev-ci]

Per changed keywords from `` to messages blips

[wzdev-ci]

Per commented

---

See also #1442 and #1441 that is the same issue. Fix will be added shortly.

[wzdev-ci]

Per commented

---

This patch fixes the problem with proximity message list and display list going out of sync due to too few proximity buttons allowed at the same time (20), by increasing the limit to 10000. I found an ID range that should be available. It also makes sure that all players get the messages they should (for switching between players), and make a real fix the beacon seen by other players problem by storing but not displaying proximity messages for other players (reverting wrong fix of this problem in #1250).

[wzdev-ci]

Per commented

---

Well, I will add the patch when trac works again :-(

I can add that the patch also removes addOilResourceProximities() which probably never worked as advertised, because it is run before vision is added, and checks if iterated objects are visible before doing anything. It is in any superfluous since visibility functions will add the blips on map load.

[wzdev-ci]

Per commented

---

Patch uploaded to http://pastebin.ca/1760845 for now.

[wzdev-ci]

Zarel changed priority from major to blocker

[wzdev-ci]

Per changed status from assigned to closed

[wzdev-ci]

Per set resolution to fixed

[wzdev-ci]

Zarel commented

---

Fixed in [9382]/[9383]