Fix multisync

[wzdev-ci]

keyword_sync_check_network resolution_fixed type_bug | by Per

---

Offscreen updates did not seem to work anymore. I traced this back to offscreen updates only setting pos.x and pos.y on a droid for most orders, and those are promptly overwritten next frame by sMove.fx and sMove.fy which are not updated. So I rewrote the code a bit to only use the floating point values. I also made it issue move command for onscreen changes when in guard order. Not sure why we do not do this for all orders, but at least guard should also be safe. DORDER_NONE is rarely used anymore.

---

Issue migrated from trac:1505 at 2022-04-15 20:59:55 -0700

[wzdev-ci]

Per uploaded file syncfix.diff (10.3 KiB)

Should remove the asserts before committing to 2.3

[wzdev-ci]

Per changed status from new to closed

[wzdev-ci]

Per set resolution to fixed

[wzdev-ci]

Per commented

---

(In [9579]) Fix offscreen updates, they were only setting droid pos.x and pos.y for most orders, and those are
promptly overwritten next frame by sMove.fx and sMove.fy which are not updated. So I rewrote the code
a bit to only use the floating point values. This closes #1505

[wzdev-ci]

Buginator commented

---

Whoops, didn't see this ticket before.
#1516 was made with the actual crashes, but game was crashing left and right. :(

When I get some more time, I will dig deeper into this patch, and see why it is so unstable for me.

[wzdev-ci]

Per changed status from closed to reopened

[wzdev-ci]

Per changed resolution from fixed to ``

[wzdev-ci]

Per changed status from reopened to assigned

[wzdev-ci]

Per changed owner from `` to Buginator

[wzdev-ci]

Per commented

---

I tested it quite a bit, and it worked fine for me. I did not up the network version, so if you forgot to use the patch on both sides, it would cause this problem.

[wzdev-ci]

Buginator commented

---

I did svn up on both, and was testing my other stuff with reverse merging that patch before.

If I didn't reverse it, then it would cause all kinds of strange bugs on either windows or linux.

As I said, I will check into it some more as soon as I get more time.

[wzdev-ci]

Per uploaded file multisyncfix2.diff (11.1 KiB)

New version. Untested in MP yet.

[wzdev-ci]

Per changed status from assigned to closed

[wzdev-ci]

Per changed resolution from `` to fixed

[wzdev-ci]

Per commented

---

(In [9681]) 2.3: Fix offscreen multisync for most orders, that was being overwritten immediately after being
received. Closes #1505 and closes #1516