Skip to content
This repository was archived by the owner on Apr 17, 2022. It is now read-only.
This repository was archived by the owner on Apr 17, 2022. It is now read-only.

Remove "Sk-" from map names #1971

Closed
Closed

Description

@wzdev-ci

keyword_maps resolution_fixed type_patch (an actual patch, not a request for one) | by Zarel


This patch removes "Sk-" and "-T1" from map names in the game hosting screen. "Sk-" is now also optional in Challenges INI files and config files.

It also breaks netcode compatibility (one-way-only; you can still join 2.3.1 host games, but 2.3.1 can't join your hosted games), but fortunately that's no longer a concern.


Issue migrated from trac:1971 at 2022-04-15 22:05:39 -0700

Activity

  1. wzdev-ci commented on Jul 4, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel uploaded file mapnames.patch (1.8 KiB)

    Remove "Sk-" and "-T1" from map names in map chooser

  2. wzdev-ci commented on Jul 4, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel changed status from new to accepted

  3. wzdev-ci commented on Jul 4, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel changed owner from `` to Zarel

  4. wzdev-ci commented on Jul 4, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel changed type from bug to patch

  5. wzdev-ci commented on Jul 4, 2010

    @wzdev-ci
    ContributorAuthor

    Per commented


    Good. Even better if you chopped off Sk- from the .lev files as well. (sed is your friend.)

  6. wzdev-ci commented on Jul 4, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel commented


    I'm afraid of the side effects that could have (there could be naming conflicts - no "Sk-" map names are reserved for legacy campaign-type maps that are still in the .lev standard).

    Plus, that'd involve changing the .lev standard, and changing EditWorld and FlaME... bit much work for something that isn't user-facing.

  7. wzdev-ci commented on Jul 10, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    FYI, this was applied in [11112] for 2.3, [11113] for trunk, and has NOT been committed in qt-trunk (yet).

    I won't close ticket until the commit to qt-trunk is done.

  8. wzdev-ci commented on Jul 10, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel changed status from accepted to assigned

  9. wzdev-ci commented on Jul 10, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel changed owner from Zarel to Buginator

  10. wzdev-ci commented on Jul 10, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel commented


    Well, I won't be committing to qt-trunk, so the rest is up to you.

  11. wzdev-ci commented on Jul 10, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator changed status from assigned to closed

  12. wzdev-ci commented on Jul 10, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator set resolution to fixed

  13. wzdev-ci commented on Jul 10, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    (In [11136]) Apply patch #1971 - Remove "Sk-" and "-T1" from map names in map chooser.

    Committed, as requested by Zarel
    Backport [11113] (trunk) [11112] (2.3)
    closes #1971

  14. wzdev-ci commented on Aug 4, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    (In [11382]) Reverting :[11136]

    Apply patch #1971 - Remove "Sk-" and "-T1" from map names in map chooser.

    Committed, as requested by Zarel
    Backport [11113] (trunk) [11112] (2.3)
    closes #1971

  15. wzdev-ci commented on Apr 7, 2011

    @wzdev-ci
    ContributorAuthor

    Terminator commented


    I dont really understand. Has this patch been reverted ? I'm makeing luncher for the game that sets a map name so I notice that not all maps have a "SK" name prefix.(new maps made with Flame dont use them). Is it possible to fit all maps to one template? I mean to make all maps with "SK" or without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions