Units near and in water water

[wzdev-ci]

resolution_fixed type_bug | by adimosh@...

---

There is a bug with the 3.0 test build. Units that are on/near water seem to get transpurted about a few trillion miles upwards.

The problem is that along with this (not to mention that this makes targeting and giving orders impossible), visibility is also nullified, however, units seem to notice each other and fire at each other as well, as if they were on the same plane. But if we have an attacking force over water, the player will not see any units that are right next to them on the ground, and will not be able to give an attack order.

I attach 2 screenshots, one showing this behavior with a few hovercraft engineers, and another with an attack on water (check minimap if the screenshot is not obvious enough).

---

Issue migrated from trac:2232 at 2022-04-16 06:41:21 -0700

[wzdev-ci]

adimosh@... uploaded file bug1.png (2286.9 KiB)

Demonstration with hovercraft engineer

[wzdev-ci]

adimosh@... uploaded file bug3.png (2357.8 KiB)

Attack on water - notice the smoke but no unit visibility (minimap for details)

[wzdev-ci]

Per commented

---

This has been seen earlier and fixed in trunk, err, master.

[wzdev-ci]

anonymous commented

---

Sorry about that, then, it gets quite difficult to follow all these types of versions.

[wzdev-ci]

Per commented

---

That was not a criticism of you, merely a note to whoever wants to fix this bug in pre-3.0.

[wzdev-ci]

Cyp commented

---

In master, fixed in Warzone2100/warzone2100@be907e3. Doesn't apply cleanly to pre-3.0, but mentioning in case it's useful.

[wzdev-ci]

Christian Ohm <chr.ohm@...> changed status from new to closed

[wzdev-ci]

Christian Ohm <chr.ohm@...> changed resolution from `` to fixed

[wzdev-ci]

Christian Ohm <chr.ohm@...> commented

---

(In Warzone2100/warzone2100@a430a29) Fix hover tanks thinking they are submarines, going under the water, and the height wrapping around.

Hover tanks float above the water, which can only be fixed when droid heights are stored in something slightly less unsigned.
Closes #1554 which was a combination of bugs or design flaws exposed in -[9619].

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9741 4a71c877-e1ca-e34f-864e-861f7616d084

Backport of be907e39948a73c19c68f701ec37bd152e7b8957, fixes #2232.

[wzdev-ci]

Christian Ohm <chr.ohm@...> commented

---

In Warzone2100/warzone2100@a430a29:

#CommitTicketReference repository="" revision="a430a29bb36d94cbc7c868f423e63161a1263cd6"
Fix hover tanks thinking they are submarines, going under the water, and the height wrapping around.

Hover tanks float above the water, which can only be fixed when droid heights are stored in something slightly less unsigned.
Closes #1554 which was a combination of bugs or design flaws exposed in -[9619].

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9741 4a71c877-e1ca-e34f-864e-861f7616d084

Backport of be907e39948a73c19c68f701ec37bd152e7b8957, fixes #2232.

[wzdev-ci]

cybersphinx changed milestone from 3.0 to unspecified

[wzdev-ci]

cybersphinx commented

---

Milestone 3.0 deleted