You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 17, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 17, 2022. It is now read-only.
Memory clobbering (dereferenced pointers) in event.c #2300
I don't really consider this "fixed", I've been looking at that part of the code lately and understanding it more and more.
This type of error likely only occurs when a Callback event uses the setTrigger function, but there could potentialy be other ways for setTrigger calls to mess things up.
Anyways, I'm sure that deferred deletion would solve this and it will also handle the case where multiple events are triggered and one calls setTrigger for one of those other events.
Activity
wzdev-ci commentedon Nov 8, 2010
buginator <buginator@...> commented
(In Warzone2100/warzone2100@1a6fb8a) Fix another memory clobbering issue. (dereferenced pointer)
Patch Author: Safety0ff
fixes #2300
Original detective work done by Ai_Tak (#1656)
Signed-off-by: buginator <buginator@>
wzdev-ci commentedon Nov 8, 2010
Buginator changed _comment0 which not transferred by tractive
wzdev-ci commentedon Nov 8, 2010
buginator <buginator@...> changed status from
newtoclosedwzdev-ci commentedon Nov 8, 2010
buginator <buginator@...> changed resolution from `` to
fixedwzdev-ci commentedon Nov 8, 2010
Buginator uploaded file
val_no_fe.txt(1.4 KiB)wzdev-ci commentedon Nov 8, 2010
Buginator uploaded file
val_with_fe.txt(2.0 KiB)wzdev-ci commentedon Nov 8, 2010
Buginator uploaded file
val_wPatch_fe.txt(1.2 KiB)wzdev-ci commentedon Nov 8, 2010
Buginator uploaded file
val_wPatch_sa_fe.txt(1.2 KiB)wzdev-ci commentedon Nov 8, 2010
Buginator uploaded file
warzone2100.gdmp-DXGWAl.txt(9.9 KiB)wzdev-ci commentedon Nov 8, 2010
Buginator changed _comment0 which not transferred by tractive
wzdev-ci commentedon Nov 8, 2010
buginator <buginator@...> commented
In Warzone2100/warzone2100@1a6fb8a:
wzdev-ci commentedon Nov 8, 2010
Buginator commented
The deal is, when you run normal valgrind, then you get val_no_fe.txt.
Notice the invalid reads.
When you set valgrind to fill the free()ed memory with 0xfe, (--fill-free=0xfe then you get val_with_fe.txt, and also the crash dump.
The final results are in val_wPatch_sa_fe.txt, and we don't have invalid reads anymore.
wzdev-ci commentedon Nov 9, 2010
cybersphinx <chr.ohm@...> commented
(In Warzone2100/warzone2100@34112c9) Fix another memory clobbering issue. (dereferenced pointer)
Patch Author: Safety0ff
fixes #2300
Original detective work done by Ai_Tak (#1656)
Signed-off-by: buginator buginator@gna.org
(cherry picked from commit 1a6fb8a7547f23ce2bd7af153ac839cba999e2b0)
wzdev-ci commentedon Nov 9, 2010
cybersphinx <chr.ohm@...> commented
In Warzone2100/warzone2100@34112c9:
wzdev-ci commentedon Nov 9, 2010
Safety0ff commented
I don't really consider this "fixed", I've been looking at that part of the code lately and understanding it more and more.
This type of error likely only occurs when a Callback event uses the setTrigger function, but there could potentialy be other ways for setTrigger calls to mess things up.
Anyways, I'm sure that deferred deletion would solve this and it will also handle the case where multiple events are triggered and one calls setTrigger for one of those other events.
I'd rather this not be "swept under the rug".
8 remaining items
wzdev-ci commentedon Nov 20, 2010
cybersphinx uploaded file
defdel-cleaned-up.patch(8.6 KiB)Rebased on a tree with 1a6fb8a7547f23ce2bd7af153ac839cba999e2b0 already reverted.
wzdev-ci commentedon Nov 20, 2010
Safety0ff uploaded file
defdelMaster.2.patch(9.5 KiB)wzdev-ci commentedon Nov 20, 2010
cybersphinx uploaded file
defdel2-cleaned-up.patch(8.6 KiB)Patch without the revert.
wzdev-ci commentedon Nov 20, 2010
Safety0ff uploaded file
defdelMaster.3.patch(9.0 KiB)Fixed a bug (notice the lack of fixme)
wzdev-ci commentedon Nov 20, 2010
Safety0ff uploaded file
defdel3-cleaned-up.patch(8.4 KiB)Same as above without revert
wzdev-ci commentedon Nov 21, 2010
safety0ff changed status from
reopenedtoclosedwzdev-ci commentedon Nov 21, 2010
safety0ff changed resolution from `` to
fixedwzdev-ci commentedon Nov 21, 2010
safety0ff commented
Fix an invalid pointer dereferencing issue in the script events system.
Closes #2300.
Changeset: 8c9e7d5bd0bcc0029ba50422b5b77089ed4202fe
wzdev-ci commentedon Nov 22, 2010
safety0ff commented
2.3: Fix an invalid pointer dereferencing issue in the script events system.
Closes #2300.
Changeset: ddfaeca6776aac765674bb0c2a5c58ecc63a978f
wzdev-ci commentedon Nov 22, 2010
safety0ff commented
3.0: Fix an invalid pointer dereferencing issue in the script events system.
Closes #2300.
Changeset: dfbceff8647ecf3e488733ed7e18e4901e4ee774
wzdev-ci commentedon Dec 16, 2010
buginator commented
Fix another memory clobbering issue. (dereferenced pointer)
Patch Author: Safety0ff
fixes #2300
Original detective work done by Ai_Tak (#1656)
Signed-off-by: buginator buginator@gna.org
(cherry picked from commit 1a6fb8a7547f23ce2bd7af153ac839cba999e2b0)
Changeset: f8517a7716e2fe11a78fc49ca73ac92b2f7d5211
wzdev-ci commentedon Dec 16, 2010
safety0ff commented
Fix an invalid pointer dereferencing issue in the script events system.
Closes #2300.
Changeset: 8c9e7d5bd0bcc0029ba50422b5b77089ed4202fe
wzdev-ci commentedon Jan 3, 2012
cybersphinx changed milestone from
3.0tounspecifiedwzdev-ci commentedon Jan 3, 2012
cybersphinx commented
Milestone 3.0 deleted