Fix map-mod support #2610
Description
keyword_map_mod_map-mod resolution_fixed type_patch (an actual patch, not a request for one) | by Zarel
As we all know, one of the biggest annoyances in Warzone are map-mods.
When a mod is bundled inside a map, the map loader will load the mod automatically and apply it to all your maps, not just the map in the map-mod. This means that if you install a map-mod as a map, the mod will be automatically loaded.
Since the mod will be loaded by the map loader and not the mod loader, the multiplayer game system will detect it as a cheat and kick you out of multiplayer games if you have a map-mod.
In short:
- If you have a map-mod, it is impossible to play a skirmish game without the mod, unless you uninstall the map-mod.
- If you have a map-mod, it is impossible to play a multiplayer game on a map other than the map-mod.
Maps can be installed automatically by joining a game hosted with it, so simply clicking on a game in the lobby is enough to prevent you from playing all other multiplayer games unless you know how to uninstall a map.
This patch fixes both these problems. As a side-effect, it is now possible to bundle a mod inside a map. So now Warzone support maps with custom tilesets, and all those other things. And you can test mods by bundling them inside a map and hosting it, no need to tell your testers to download your mod anymore!
Since the current broken handling of map-mods can lead to crashes that my patch fixes, I'm setting priority to major, and recommending that this patch be backported to 2.3-branch.
The patch fixes these by extending the Override Mods system to work with Override Maps. When starting a game, only the active map should be loaded. This may slow down game starting slightly, but shouldn't be significant enough to be noticeable.
The patch is here: https://github.com/Zarel/warzone2100/compare/topic/mapmodloader.patch
The pull request is here: Warzone2100/warzone2100#9
Comments?
Issue migrated from trac:2610 at 2022-04-16 07:56:17 -0700