Skip to content
This repository was archived by the owner on Apr 17, 2022. It is now read-only.
This repository was archived by the owner on Apr 17, 2022. It is now read-only.

Scale unit limits back down to 2.3 levels #2812

Closed

Description

@wzdev-ci

resolution_fixed type_patch (an actual patch, not a request for one) | by Safety0ff


This is a recurring complaint, so we should scale this down to 2.3 for the time being.

Patch is untested but should work (based on looking how the limit is determined and the code that uses this constant).


Issue migrated from trac:2812 at 2022-04-16 08:28:08 -0700

Activity

  1. wzdev-ci commented on Jul 6, 2011

    @wzdev-ci
    ContributorAuthor

    Safety0ff uploaded file unitlimits.diff (1.6 KiB)

  2. wzdev-ci commented on Jul 8, 2011

    @wzdev-ci
    ContributorAuthor

    dak180 changed _comment0 which not transferred by tractive

  3. wzdev-ci commented on Jul 8, 2011

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    This should also be reverted.
    [61ed2a1505cf2ae8a44e]

    The main issue is that all these changes ignore the limits the game's engine can handle...
    Brute force is no fun.

  4. wzdev-ci commented on Jul 9, 2011

    @wzdev-ci
    ContributorAuthor

    dak180 commented


    Replying to Warzone2100/old-trac-import#2812 (comment:1):

    This should also be reverted.
    [61ed2a1505cf2ae8a44e]

    The main issue is that all these changes ignore the limits the game's engine can handle...
    Brute force is no fun.
    I would not mind keeping the new max values if there were a way to set the default limits back to the previous levels.

  5. wzdev-ci commented on Jul 17, 2011

    @wzdev-ci
    ContributorAuthor

    vexed commented


    Why #define MAX_CONSTRUCTOR_DROIDS 30 ?
    This was set to 15 back in 61ed2a1505cf2ae8a44e

    The only other change from that patch is the unit limit.

  6. wzdev-ci commented on Jul 17, 2011

    @wzdev-ci
    ContributorAuthor

    Safety0ff commented


    I simply "scaled back" the limits. Also, I didn't look at that the other commit.

  7. wzdev-ci commented on Jul 17, 2011

    @wzdev-ci
    ContributorAuthor

    vexed changed status from new to closed

  8. wzdev-ci commented on Jul 17, 2011

    @wzdev-ci
    ContributorAuthor

    vexed changed resolution from `` to fixed

  9. wzdev-ci commented on Jul 17, 2011

    @wzdev-ci
    ContributorAuthor

    vexed commented


    Revert "Bump max structure limits, now that UI supports them."

    This reverts commit 61ed2a1505cf2ae8a44e4a23d6abafb142235160.
    Our engine can't currently support all these units.

    Once a new engine is in place, we can increase limits again.

    Closes #2812

    • Changeset: [/changeset/810463edfadd9ad3a54801eb99bf1e3e736b0775 810463edfadd9ad3a54801eb99bf1e3e736b0775]
    • URL: [810463]edfadd9ad3a54801eb99bf1e3e736b0775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions