[patch] Don't use TEXTURE_RECTANGLE for FMVs

[wzdev-ci]

keyword_fmv resolution_fixed type_patch (an actual patch, not a request for one) | by Zarel

---

Since cybersphinx hasn't ticketed this, I shall:

---

Here's a patch to make Warzone use regular textures to display the videos. This is the "hacky" version, the one that only needs a small and localized amount of changed code.

It uses one texture with a fixed size for videos (the old code allocated a new texture once per frame). The texture size is set at 512x512, which is enough for the current 320x240 videos. I think at least for 2.2 that is acceptable, since we don't have larger videos anyway. There are no error checks yet, so any video larger than 512x512 will behave badly.

The proper way would be to use a struct for the video info that is set up for every video played, where the texture is allocated according to video size etc., but that might make things unstable, so not suitable for 2.2 imo.

I've changed the multiplier to the texcoords from 255 to 256, since the matrix is set up as 1/256. This should be changed any way, I guess.

In addition to this patch the message about the radar not working should probably be removed, and since the YUV converter seems YUV420 specific, a check for other formats.

---

Updated patch.

I've moved texture creation from video_write() into seq_Play(), where it makes more sense, and added a check for the video size. I've also removed the radar warning message, and added a check for the YUV420 format (though those should be committed separately).

---

Issue migrated from trac:375 at 2022-04-15 18:08:20 -0700

[wzdev-ci]

Zarel uploaded file wz-no-rectangular-textures-2.patch (6.8 KiB)

Don't use TEXTURE_RECTANGLE for rendering FMVs

[wzdev-ci]

Buginator changed status from new to closed

[wzdev-ci]

Buginator set resolution to fixed

[wzdev-ci]

Buginator commented

---

and since it is fixed in [7071], closing.

[wzdev-ci]

Buginator commented

---

I mean [7021]

[wzdev-ci]

Buginator removed milestone (was 2.2)

[wzdev-ci]

Buginator commented

---

Milestone 2.2 deleted