Crashes in glcSaveGLState

[wzdev-ci]

resolution_fixed type_bug | by raycast

---

Freshly compiled WZ master would crash for me, until I applied attached patch.
The crash happens in glGetPointerv, so I wrapped it in a check whether it actually is needed. Now warzone starts, I havn't tested much more.

---

Issue migrated from trac:3818 at 2022-04-16 10:44:20 -0700

[wzdev-ci]

raycast uploaded file wz-gl.diff (1.7 KiB)

[wzdev-ci]

vexed commented

---

This patch should be sent upstream to the quesoGLC people on sourceforge.

What video card & OS do you have anyway, drivers seems to be reporting the vertex arrays incorrectly ?
Also, you may want to modify it slightly

if (inGLState->vertexArray)

is good enough.

[wzdev-ci]

vexed changed blocking which not transferred by tractive

[wzdev-ci]

vexed changed blockedby which not transferred by tractive

[wzdev-ci]

raycast commented

---

I belive not trusting GL_TRUE to be C true would be good style.

I'm on Linux and intel. It worked a few weeks before, but apparently some recent mesa/SDL/intel-driver/something update or git-pull changed this.

I don't think my graphics driver is reporting the vertex array incorrectly. I belive just the return value is undefined when a disabled feature is retrieved. Of course, retrieving a feature that was disabled doesn't make much sense anyway.

[wzdev-ci]

Cyp commented

---

#3822 probably duplicate of this.

[wzdev-ci]

Cyp commented

---

Sent upstream — http://quesoglc.git.sourceforge.net/git/gitweb.cgi?p=quesoglc/quesoglc;a=commit;h=e2f382d

The 0.7 release branch wasn't patched, but doesn't seem to be any corresponding code to patch, anyway.

[wzdev-ci]

cybersphinx changed status from new to closed

[wzdev-ci]

cybersphinx changed resolution from `` to fixed

[wzdev-ci]

cybersphinx commented

---

Applied in 78a13deb19537497f15fc118ca5f501389a3e90b.

[wzdev-ci]

Per commented

---

This patch creates new problems. See #3834