Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Patch: Conversion Structures.txt --> Sctructure.ini #3965

Closed
wzdev-ci opened this issue Feb 26, 2013 · 9 comments
Closed

Patch: Conversion Structures.txt --> Sctructure.ini #3965

wzdev-ci opened this issue Feb 26, 2013 · 9 comments

Comments

@wzdev-ci
Copy link
Contributor

keyword_ini resolution_fixed type_patch (an actual patch, not a request for one) | by Reg312


Conversion Structures.txt --> Sctructure.ini

https://github.com/crabster/warzone2100/commit/3cd09838b1f26693f70d17d1ddff383d0bbf339d

open for suggestions and criticism

do not use diff for this patch, cause new file added.

Tested:

  1. Scirmish
  2. Campaigh
  3. Some Defenses
  4. Some sctucture functions (research, repair)

Issue migrated from trac:3965 at 2022-04-16 10:54:28 -0700

@wzdev-ci
Copy link
Contributor Author

Reg312 changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Reg312 changed _comment1 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Reg312 commented


Replying to [#3965 Reg312]:
new version of patch
https://github.com/crabster/warzone2100/commit/9ad1010c9d12cd26437c0fe8b1f7c60b6f056fb1

corrected typos in comments

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 3, 2013

Per changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 3, 2013

Per changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 3, 2013

Per commented


../../src/structure.cpp: In function ‘bool loadStructureStats(QString)’:
../../src/structure.cpp:492:169: error: cannot pass objects of non-trivially-copyable type ‘class QString’ through ‘...’
../../src/structure.cpp:492:169: error: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘QString’ [-Werror=format]
../../src/structure.cpp:500:185: error: cannot pass objects of non-trivially-copyable type ‘class QString’ through ‘...’
../../src/structure.cpp:500:185: error: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘QString’ [-Werror=format]
../../src/structure.cpp:533:163: error: cannot pass objects of non-trivially-copyable type ‘class QString’ through ‘...’
../../src/structure.cpp:533:163: error: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘QString’ [-Werror=format]
../../src/structure.cpp:542:158: error: cannot pass objects of non-trivially-copyable type ‘class QString’ through ‘...’
../../src/structure.cpp:542:158: error: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘QString’ [-Werror=format]
../../src/structure.cpp:554:142: error: cannot pass objects of non-trivially-copyable type ‘class QString’ through ‘...’
../../src/structure.cpp:554:142: error: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘QString’ [-Werror=format]
../../src/structure.cpp:566:148: error: cannot pass objects of non-trivially-copyable type ‘class QString’ through ‘...’
../../src/structure.cpp:566:148: error: format ‘%s’ expects argument of type ‘char*’, but argument 5 has type ‘QString’ [-Werror=format]

Need to use QString's toUtf8().constData() when passing to assert statements.

@wzdev-ci
Copy link
Contributor Author

Per commented


Committed in 066ba771b7bab49d8cf6b0920f06feec745c2f93

@wzdev-ci
Copy link
Contributor Author

Per changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Per changed resolution from `` to fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant